This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
ethcore: fix ancient block sync #9407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-pleasereview 🤓
5chdn
added
the
A1-onice 🌨
This was referenced Aug 23, 2018
ascjones
reviewed
Aug 24, 2018
Closed
tomusdrw
approved these changes
Aug 24, 2018
| let mut imported = HashSet::new(); | ||
| let blocks = self.blocks.drain(); | ||
| let count = blocks.len(); | ||
|
|
||
| for block_and_receipts in blocks { |
There was a problem hiding this comment.
Might be worth to turn this loop into a closure and return an enum Importer { Reset, Bad, Imported(HashSet) } instead of setting the flags.
That said, refactoring can be left to a separate PR.
tomusdrw
reviewed
Aug 24, 2018
| if bad { | ||
| return Err(BlockDownloaderImportError::Invalid); | ||
| } | ||
|
|
||
| if self.blocks.is_empty() { |
There was a problem hiding this comment.
Is that correct? Seems that if we fail on the last block we are not going to return an error?
ascjones
removed
the
A1-onice 🌨
5chdn
added
A8-looksgood 🦄
andresilva
added
A1-onice 🌨
|
@tomusdrw I didn't notice any changes on regular sync, seemed to be working fine. But it seems like this PR doesn't fix the original issue completely (#9300 (comment)). So I'm going to investigate this a bit more and I'll put this |
This was referenced Aug 30, 2018
5chdn
added
the
A3-stale 🍃
|
What's the status? |
This was referenced Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9300 and fixes #7008. Merge after #9381.