This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
remove block view! #9397
Merged
remove block view! #9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A3-inprogress ⏳
|
I decided to remove |
|
Can you tell us why you want to remove it? What's wrong with it? |
|
it unsafely |
niklasad1
reviewed
Aug 24, 2018
|
|
||
| /// Enact the block given by `block_bytes` using `engine` on the database `db` with given `parent` block header | ||
| fn enact_bytes( | ||
| block_bytes: &[u8], | ||
| block_bytes: Vec<u8>, |
There was a problem hiding this comment.
Can you explain the motivation behind using a Vec instead of a Slice here?
Vec is less efficient (syscall overhead) and consumes more memory (3 words instead of 2)?
There was a problem hiding this comment.
Looks like test functions
There was a problem hiding this comment.
ah lol thanks, never mind 😃
niklasad1
approved these changes
Aug 24, 2018
ascjones
approved these changes
Aug 24, 2018
5chdn
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Aug 30, 2018
* master: evmbin: Fix gas_used issue in state root mismatch and handle output better (#9418) Update hardcoded sync (#9421) Add block reward contract config to ethash and allow off-chain contracts (#9312) Private packets verification and queue refactoring (#8715) Update tobalaba.json (#9419) docs: add parity ethereum logo to readme (#9415) build: update rocksdb crate (#9414) Updating the CI system (#8765) Better support for eth_getLogs in light mode (#9186) Add update docs script to CI (#9219) `gasleft` extern implemented for WASM runtime (kip-6) (#9357) block view! removal in progress (#9397) Prevent sync restart if import queue full (#9381) nonroot CentOS Docker image (#9280) ethcore: kovan: delay activation of strict score validation (#9406)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.