This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Improve return data truncate logic #9254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
debris
approved these changes
Aug 7, 2018
NikVolf
reviewed
Aug 7, 2018
| if !is_valid_range(offset, size) { | ||
| return ReturnData::empty() | ||
| return ReturnData::empty(); |
NikVolf
approved these changes
Aug 7, 2018
ordian
added a commit
to ordian/parity
that referenced
this pull request
Aug 10, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: ethcore: add transition flag for transaction permission contract (openethereum#9275) Remove all dapp permissions related settings (openethereum#9120) Improve return data truncate logic (openethereum#9254) Update wasm-tests hash (openethereum#9295) Implement KIP4: create2 for wasm (openethereum#9277) Fix loop start value (openethereum#9285) Avoid using $HOME if not necessary (openethereum#9273) Fix path to parity.h (openethereum#9274)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's
Vecallocator will never change the init pointer, sodrainwill do copy anyway (with the unwanted tail data). This PR fixes it by only attempting to truncate ifoffsetis0, and for other cases, just create a newVec.