Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

remove ssl from dockerfiles #9195

Merged
merged 1 commit into from
Jul 26, 2018
Merged

remove ssl from dockerfiles #9195

merged 1 commit into from
Jul 26, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 23, 2018

closes #8880

@paritytech/ci can you check if modified dockerfiles build fine?

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M0-build 🏗 Building and build system. labels Jul 23, 2018
@ddorgan
Copy link
Collaborator

ddorgan commented Jul 23, 2018

@debris somewhat unrelated but it won't build now due to it trying to cd into the parity directory instead of parity-ethereum (or checkout the directory as parity instead of parity-ethereum)...

  stable installed - rustc 1.27.2 (58cc626de 2018-07-18)


Rust is installed now. Great!

To get started you need Cargo's bin directory ($HOME/.cargo/bin) in your PATH
environment variable. Next time you log in this will be done automatically.

To configure your current shell run source $HOME/.cargo/env
Cloning into 'parity-ethereum'...
/bin/sh: 1: cd: can't cd to parity

@debris
Copy link
Collaborator Author

debris commented Jul 23, 2018 •
edited
Loading

@ddorgan I see, I will fix it. btw. what script produced the output that you just pasted?

edit. imo, it's not a problem with a dockerfile but with the script you run :)

@andresilva
Copy link
Contributor

andresilva commented Jul 23, 2018 •
edited
Loading

@debris https://github.com/paritytech/parity-ethereum/pull/9195/files#diff-c76ef29aae3295079b52e4f353ad1d7cL39
Maybe this is what @ddorgan is referring to.

@debris
Copy link
Collaborator Author

debris commented Jul 23, 2018

god, we are we pulling ethereum using git? docker should use local version of the repo

@debris
Copy link
Collaborator Author

debris commented Jul 23, 2018

I'll fix it

@debris
Copy link
Collaborator Author

debris commented Jul 23, 2018

oh, I see that it contains a BUILD_TAG flag... but it's a stupid solution, cause different branches of parity may have different requirements

@5chdn 5chdn added this to the 2.1 milestone Jul 24, 2018
@5chdn 5chdn mentioned this pull request Jul 24, 2018
Merged
15 tasks
@andresilva
Copy link
Contributor

@debris Are you going to push those fixes to this branch or should we merge this PR? We can also remove ssl requirements from snapcraft definition (https://github.com/paritytech/parity-ethereum/blob/master/snap/snapcraft.yaml#L36).

@debris
Copy link
Collaborator Author

debris commented Jul 26, 2018

@andresilva no, let's make a separate pr for them

@andresilva andresilva merged commit 4ddccfa into master Jul 26, 2018
@debris debris deleted the docker_cleanup branch July 26, 2018 13:02
@5chdn 5chdn mentioned this pull request Jul 26, 2018
Merged
28 tasks
5chdn pushed a commit that referenced this pull request Jul 26, 2018
@debris @5chdn
remove ssl from dockerfiles, closes #8880 (#9195)
bfa5f40
JohnnySheffield added a commit to JohnnySheffield/parity-ethereum that referenced this pull request Jul 27, 2018
@JohnnySheffield
Merge branch 'master' into docker-centos
611ef25 
* master:
  add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230)
  fix typo (openethereum#9232)
  Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221)
  Allow old blocks from peers with lower difficulty (openethereum#9226)
  Removes duplicate libudev-dev from Dockerfile (openethereum#9220)
  snap: remove ssl dependencies from snapcraft definition (openethereum#9222)
  remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195)
@JohnnySheffield
Copy link
Contributor

@debris Please take into consideration final image size that you get when you

a) ADD local repo, then RUN build, clean
or
b) RUN git clone, build parity, clean

It seems to me image sizes that you get with b) are considerably smaller, as you can efficiently clean up after yourself. When you ADD, the files end up in intermediary image, and even if you clean up in a subsequent RUN command, the final image size is larger.

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 29, 2018
ordian added a commit to ordian/parity that referenced this pull request Jul 31, 2018
@ordian
resolve merge conflicts
294c313 
* 'master' of https://github.com/paritytech/parity:
  removed client error (openethereum#9253)
  Implement EIP-1052 (EXTCODEHASH) and fix several issues in state account cache (openethereum#9234)
  Improve Tracer documentation (openethereum#9237)
  Update Dockerfile (openethereum#9242)
  block cleanup (openethereum#9117)
  Increase the number of sessions. (openethereum#9203)
  add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230)
  fix typo (openethereum#9232)
  Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221)
  Allow old blocks from peers with lower difficulty (openethereum#9226)
  Removes duplicate libudev-dev from Dockerfile (openethereum#9220)
  snap: remove ssl dependencies from snapcraft definition (openethereum#9222)
  remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195)
  Insert PROOF messages for some cases in blockchain (openethereum#9141)
  [Chain] Add more bootnodes (openethereum#9174)
  ethcore: update bn version (openethereum#9217)
  deserialize block only once during verification (openethereum#9161)
  Simple build instruction fix (openethereum#9215)
  Added --tx-queue-no-early-reject flag to disable early tx queue rejects (openethereum#9143)
5chdn added a commit that referenced this pull request Aug 31, 2018
@5chdn
beta backports for 2.0.3 (#9229)
a0a2bed 
* parity-version: bump beta to 2.0.2

* remove ssl from dockerfiles, closes #8880 (#9195)

* snap: remove ssl dependencies from snapcraft definition (#9222)

* parity-version: bump beta to 2.0.3

* Remove all dapp permissions related settings (#9120)

* Completely remove all dapps struct from rpc

* Remove unused pub use

* Remove dapp policy/permission func in ethcore

* Remove all dapps settings from rpc

* Fix rpc tests

* Use both origin and user_agent

* Address grumbles

* Address grumbles

* Fix tests

* Check if synced when using eth_getWork (#9193) (#9210)

* Check if synced when using eth_getWork (#9193)

* Don't use fn syncing

* Fix identation

* Fix typo

* Don't check for warping

* rpc: avoid calling queue_info twice on eth_getWork

* Fix potential as_usize overflow when casting from U256 in miner (#9221)

* Allow old blocks from peers with lower difficulty (#9226)

Previously we only allow downloading of old blocks if the peer
difficulty was greater than our syncing difficulty. This change allows
downloading of blocks from peers where the difficulty is greater then
the last downloaded old block.

* Update Dockerfile (#9242)

* Update Dockerfile

fix Docker build

* fix dockerfile paths: parity -> parity-ethereum (#9248)

* Propagate transactions for next 4 blocks. (#9265)

Closes #9255 

This PR also removes the limit of max 64 transactions per packet, currently we only attempt to prevent the packet size to go over 8MB. This will only be the case for super-large transactions or high-block-gas-limit chains.

Patching this is important only for chains that have blocks that can fit more than 4k transactions (over 86M block gas limit)

For mainnet, we should actually see a tiny bit faster propagation since instead of computing 4k pending set, we only need `4 * 8M / 21k = 1523` transactions.

Running some tests on `dekompile` node right now, to check how it performs in the wild.

* Update tobalaba.json (#9313)

* Fix load share (#9321)

* fix(light_sync): calculate `load_share` properly

* refactor(api.rs): extract `light_params` fn, add test

* style(api.rs): add trailing commas

* ethcore: fix pow difficulty validation (#9328)

* ethcore: fix pow difficulty validation

* ethcore: validate difficulty is not zero

* ethcore: add issue link to regression test

* ethcore: fix tests

* ethcore: move difficulty_to_boundary to ethash crate

* ethcore: reuse difficulty_to_boundary and boundary_to_difficulty

* ethcore: fix grumbles in difficulty_to_boundary_aux

* Light client `Provide default nonce in transactions when it´s missing` (#9370)

* Provide `default_nonce` in tx`s when it´s missing

When `nonce` is missing in a `EthTransaction` will cause it to fall in
these cases provide `default_nonce` value instead!

* Changed http:// to https:// on Yasm link (#9369)

Changed http:// to https:// on Yasm link in README.md

* Provide `default_nonce` in tx`s when it´s missing

When `nonce` is missing in a `EthTransaction` will cause it to fall in
these cases provide `default_nonce` value instead!

* Address grumbles

* ethcore: kovan: delay activation of strict score validation (#9406)

* Better support for eth_getLogs in light mode (#9186)

* Light client on-demand request for headers range.

* Cache headers in HeaderWithAncestors response.

Also fulfills request locally if all headers are in cache.

* LightFetch::logs fetches missing headers on demand.

* LightFetch::logs limit the number of headers requested at a time.

* LightFetch::logs refactor header fetching logic.

* Enforce limit on header range length in light client logs request.

* Fix light request tests after struct change.

* Respond to review comments.

* Add update docs script to CI (#9219)

* Add update docs script to CI

Added a script to CI that will use the jsonrpc tool to update rpc
documentation then commit and push those to the wiki repo.

* fix gitlab ci lint

* Only apply jsonrpc docs update on tags

* Update gitlab-rpc-docs.sh

* Copy correct parity repo to jsonrpc folder

Copy correct parity repo to jsonrpc folder before attempting to build docs since the CI runner clones the repo as parity and not parity-ethereum.

* Fix JSONRPC docs CI job

Update remote config in wiki repo before pushing changes using a github
token for authentication. Add message to wiki tag when pushing changes.
Use project directory to correctly copy parity code base into the
jsonrpc repo for doc generation.

* Fix set_remote_wiki function call in CI

* Prevent blockchain & miner racing when accessing pending block. (#9310)

* Prevent blockchain & miner racing when accessing pending block.

* Fix unavailability of pending block during reseal.

* Prevent sync restart if import queue full (#9381)

* Add POA Networks: Core and Sokol (#9413)

* ethcore: add poa network and sokol chainspecs

* rpc: simplify chain spec docs

* cli: rearrange networks by main/test and size/range

* parity: don't blacklist 0x00a328 on sokol testnet

* parity: add sokol and poanet to params and clean up a bit, add tests

* ethcore: add the poa networks and clean up a bit

* ethcore: fix path to poacore chain spec

* parity: rename poa networks to poacore and poasokol

* parity: fix configuration tests

* parity: fix parameter tests

* ethcore: rename POA Core and POA Sokol

* Update tobalaba.json (#9419)

* Update hardcoded sync (#9421)

- Update foundation hardcoded header to block 6219777 
- Update ropsten hardcoded header to block 3917825 
- Update kovan hardcoded header to block 8511489
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@5chdn 5chdn 5chdn approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.

Cleanup dependencies from Dockerfiles
5 participants
@debris @ddorgan @andresilva @JohnnySheffield @5chdn