This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove node-health #9119
Merged
Remove node-health #9119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Jul 16, 2018
| ARG arg_ntp_servers: (String) = "0.parity.pool.ntp.org:123,1.parity.pool.ntp.org:123,2.parity.pool.ntp.org:123,3.parity.pool.ntp.org:123", or |c: &Config| c.misc.as_ref()?.ntp_servers.clone().map(|vec| vec.join(",")), | ||
| "--ntp-servers=[HOSTS]", | ||
| "Comma separated list of NTP servers to provide current time (host:port). Used to verify node health. Parity uses pool.ntp.org NTP servers; consider joining the pool: http://www.pool.ntp.org/join.html", | ||
|
|
There was a problem hiding this comment.
I believe this should be deprecated as per: #9036
There was a problem hiding this comment.
It also needs to be added to https://github.com/paritytech/parity/blob/master/parity/deprecated.rs, so that it produces a warning message if the deprecated arg is used.
ascjones
added
A8-looksgood 🦄
andresilva
reviewed
Jul 17, 2018
rpc/src/v1/impls/parity.rs
Outdated
| use updater::{Service as UpdateService}; | ||
| use jsonrpc_core::{BoxFuture, Result}; | ||
| use jsonrpc_core::futures::{future, Future}; | ||
| use jsonrpc_core::futures::{future}; |
There was a problem hiding this comment.
use jsonrpc_core::futures::future;
parity/cli/mod.rs
Outdated
| logging: Option<String>, | ||
| log_file: Option<String>, | ||
| color: Option<bool>, | ||
| ports_shift: Option<u16>, | ||
| unsafe_expose: Option<bool>, | ||
| _legacy_ntp_servers: Option<Vec<String>>, |
There was a problem hiding this comment.
I know we did this for some other deprecated options, but do we need to keep this fields? Seems like it isn't used anywhere besides when parsing the argument. We can use or |_| None in that case.
There was a problem hiding this comment.
So I removed this field in my last commit. But the other ones are still there. Probably to be removed in the scope of another pr?
rpc/src/v1/tests/mocked/parity.rs
Outdated
| @@ -21,7 +21,6 @@ use ethcore_logger::RotatingLogger; | |||
| use ethereum_types::{Address, U256, H256}; | |||
| use ethstore::ethkey::{Generator, Random}; | |||
| use miner::pool::local_transactions::Status as LocalTransactionStatus; | |||
| use node_health::{self, NodeHealth}; | |||
| use parity_reactor; | |||
|
The NTP code was my first contribution to parity 😛. |
5chdn
pushed a commit
that referenced
this pull request
Jul 24, 2018
* Remove node-health * Remove ntp_servers * Add --ntp-servers as legacy instead of removing it * Add --ntp-servers to deprecated args * Remove unused stuff * Remove _legacy_ntp_servers
5chdn
added a commit
that referenced
this pull request
Jul 26, 2018
* parity-version: bump beta to 2.0.1 * ci: update version strings for snaps * Be more graceful on Aura difficulty validation (#9164) * Be more graceful on Aura difficulty validation * test: rejects_step_backwards * test: proposer_switching * test: rejects_future_block * test: reports_skipped * test: verify_empty_seal_steps * Remove node-health (#9119) * Remove node-health * Remove ntp_servers * Add --ntp-servers as legacy instead of removing it * Add --ntp-servers to deprecated args * Remove unused stuff * Remove _legacy_ntp_servers * parity: fix UserDefaults json parser (#9189) * parity: fix UserDefaults json parser * parity: use serde_derive for UserDefaults * parity: support deserialization of old UserDefault json format * parity: make UserDefaults serde backwards compatible * parity: tabify indentation in UserDefaults * Fix bugfix hard fork logic (#9138) * Fix bugfix hard fork logic * Remove dustProtectionTransition from bugfix category EIP-168 is not enabled by default * Remove unnecessary 'static * Disable per-sender limit for local transactions. (#9148) * Disable per-sender limit for local transactions. * Add a missing new line. * rpc: fix is_major_importing sync state condition (#9112) * rpc: fix is_major_importing sync state condition * rpc: fix informant printout when waiting for peers * fix verification in ethcore-sync collect_blocks (#9135) * docker: update hub dockerfile (#9173) * update Dockerfile for hub update to Ubuntu Xenial 16.04 fix cmake version * docker: fix tab indentation in hub dockerfile * rpc: fix broken merge * rcp: remove node_health leftover from merge * rpc: remove dapps leftover from merge
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-healthand theparity_nodeHealthRPCntp_servers, as it was only used bynode-healthto check if local clock is sync.Parity UI starting from v0.3.0 is free from
parity_nodeHealthcalls. The info returned by node-health has been replaced by: