-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
The changes I did to |
@andresilva are you still working on this? |
Seems like nobody reviewed it. @sorpaas can you take a look? I'll try to as well but I'm out-of-the-loop with parity-ethereum stuff. |
I remember the issue is with light client. Probably @andresilva can clarify more. I didn't find anywhere that we write finalization info to light client currently (or do we?), so for the purpose of this refactoring PR, it may be okay to continue to ignore finality info for light client? |
The light client does track finality, but only for blocks which register validator set changes. Requires finality proofs though. |
I haven't worked on this further after submitting the original PR. I think the changes for the full client make sense, but I changed signature of I think the easiest way to integrate this is to keep the existing finality tracking logic for the light client, this probably requires us to introduce a special light version of |
852a96a
to
db7bf44
Compare
b11fd0b
to
633196f
Compare
The full client now tracks finality by querying the engine on each block import, and it also persists the finalization state to the DB. For the light client current it doesn't persist finality information and only keeps track of finality for epoch signals, by calling `is_epoch_end_light`. This method implements the previously existing logic of building finality for all the blocks in the current epoch and then checking the finalized blocks against the transition store.
633196f
to
48df25b
Compare
- missing docs for is_epoch_end_light - unused method unfinalized_hashes in RollingFinality
Adding patch label to make sure this ends up in 2.1-beta once branched out. |
Please rebase on master |
Please reopen when ready |
Implement
ancestry_actions
to mark finalized blocks using the existing rolling finality. I've also changed theis_epoch_end
method so that it gets the recently finalized blocks as argument and can check the transition store using that.