Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update hidapi #9108

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Update hidapi #9108

merged 1 commit into from
Jul 13, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 12, 2018

fixes #7542

@debris debris added A0-pleasereview 🤓 Pull request needs code review. B0-patchthis M4-core ⛓ Core client code / Rust. labels Jul 12, 2018
@5chdn 5chdn added this to the 2.1 milestone Jul 12, 2018
@5chdn 5chdn mentioned this pull request Jul 12, 2018
15 tasks
@5chdn 5chdn mentioned this pull request Jul 12, 2018
12 tasks
@niklasad1
Copy link
Collaborator

Anyone that has tested that this solves the issue?

@5chdn 5chdn merged commit ab33030 into master Jul 13, 2018
@5chdn 5chdn deleted the update_hidapi branch July 13, 2018 09:04
@debris
Copy link
Collaborator Author

debris commented Jul 13, 2018

It was reproducible only on Hackintosh. I know noone who has it, but the stack trace was quite obvious.

5chdn pushed a commit that referenced this pull request Jul 13, 2018
5chdn pushed a commit that referenced this pull request Jul 13, 2018
5chdn added a commit that referenced this pull request Jul 17, 2018
* parity-version: stabelize 1.11

* parity-version: bump stable to 1.11.7

* Don't fetch snapshot chunks at random (#9088)

* Offload cull to IoWorker.

* Limit the number of transactions in pending set (#8777)

* Unordered iterator.

* Use unordered and limited set if full not required.

* Split timeout work into smaller timers.

* Avoid collecting all pending transactions when mining

* Remove println.

* Use priority ordering in eth-filter.

* Fix ethcore-miner tests and tx propagation.

* Review grumbles addressed.

* Add test for unordered not populating the cache.

* Fix ethcore tests.

* Fix light tests.

* Fix ethcore-sync tests.

* Fix RPC tests.

* Make sure to produce full blocks.

* Update hidapi, fixes #7542 (#9108)

* docker: add cmake dependency (#9111)

* Fix miner tests.

* Revert "Make sure to produce full blocks."

This reverts commit b12d592.

* Update light client hardcoded headers (#9098)

* Insert Kovan hardcoded headers until #7690241

* Insert Kovan hardcoded headers until block 7690241

* Insert Ropsten hardcoded headers until #3612673

* Insert Mainnet hardcoded headers until block 5941249

* Make sure to produce full blocks. (#9115)

* Insert ETC (classic) hardcoded headers until block #6170625 (#9121)

* fix verification in ethcore-sync collect_blocks (#9135)

* `evm bench` fix broken dependencies (#9134)

* `evm bench` use valid dependencies

Benchmarks of the `evm` used stale versions of a couple a crates that
this commit fixes!

* fix warnings
5chdn added a commit that referenced this pull request Jul 17, 2018
* parity-version: betalize 2.0

* Multiple improvements to discovery ping handling (#8771)

* discovery: Only add nodes to routing table after receiving pong.

Previously the discovery algorithm would add nodes to the routing table
before confirming that the endpoint is participating in the protocol. This
now tracks in-flight pings and adds to the routing table only after receiving
a response.

* discovery: Refactor packet creation into its own function.

This function is useful inside unit tests.

* discovery: Additional testing for new add_node behavior.

* discovery: Track expiration of pings to non-yet-in-bucket nodes.

Now that we may ping nodes before adding to a k-bucket, the timeout tracking
must be separate from BucketEntry.

* discovery: Verify echo hash on pong packets.

Stores packet hash with in-flight requests and matches with pong response.

* discovery: Track timeouts on FIND_NODE requests.

* discovery: Retry failed pings with exponential backoff.

UDP packets may get dropped, so instead of immediately booting nodes that fail
to respond to a ping, retry 4 times with exponential backoff.

* !fixup Use slice instead of Vec for request_backoff.

* Add separate database directory for light client (#8927) (#9064)

* Add seperate default DB path for light client (#8927)

* Improve readability

* Revert "Replace `std::env::home_dir` with `dirs::home_dir` (#9077)" (#9097)

* Revert "Replace `std::env::home_dir` with `dirs::home_dir` (#9077)"

This reverts commit 7e77932.

* Restore some of the changes

* Update parity-common

* Offload cull to IoWorker. (#9099)

* Fix work-notify. (#9104)

* Update hidapi, fixes #7542 (#9108)

* docker: add cmake dependency (#9111)

* Update light client hardcoded headers (#9098)

* Insert Kovan hardcoded headers until #7690241

* Insert Kovan hardcoded headers until block 7690241

* Insert Ropsten hardcoded headers until #3612673

* Insert Mainnet hardcoded headers until block 5941249

* Make sure to produce full blocks. (#9115)

* Insert ETC (classic) hardcoded headers until block #6170625 (#9121)

* fix verification in ethcore-sync collect_blocks (#9135)

* Completely remove all dapps struct from rpc (#9107)

* Completely remove all dapps struct from rpc

* Remove unused pub use

* `evm bench` fix broken dependencies (#9134)

* `evm bench` use valid dependencies

Benchmarks of the `evm` used stale versions of a couple a crates that
this commit fixes!

* fix warnings

* Update snapcraft.yaml (#9132)
@i5hi
Copy link

i5hi commented Nov 5, 2018

just tried compiling the latest release and get this hidapi error ((

d76:~/nodes/parity-ethereum-2.1.4$ RUST_BACKTRACE=1 cargo build --release --features final
Downloading log v0.4.6
Downloading lazy_static v1.2.0
Downloading byteorder v1.2.7
Downloading rayon v1.0.3
Downloading cfg-if v0.1.6
Downloading fixed-hash v0.2.5
Downloading syn v0.15.18
Downloading quote v0.6.9
Downloading tokio-io v0.1.10
Downloading memchr v2.1.1
Downloading aho-corasick v0.6.9
Downloading utf8-ranges v1.0.2
Downloading ucd-util v0.1.2
Downloading tokio-threadpool v0.1.8
Downloading tokio-uds v0.2.3
Downloading tokio-fs v0.1.4
Compiling cfg-if v0.1.6
Compiling rand_core v0.3.0
Compiling lazy_static v1.2.0
Compiling byteorder v1.2.7
Compiling rayon v1.0.3
Compiling futures v0.1.25
Compiling proc-macro2 v0.4.20
Compiling serde v1.0.80
Compiling lazycell v1.2.0
Compiling version_check v0.1.5
Compiling httparse v1.3.3
Compiling num-traits v0.2.6
Compiling gcc v0.3.55
Compiling ucd-util v0.1.2
Compiling safemem v0.3.0
Compiling rustc-hex v1.0.0
Compiling utf8-ranges v1.0.2
Compiling termcolor v1.0.4
Compiling mio-named-pipes v0.1.6
Compiling crossbeam-utils v0.2.2
Compiling log v0.4.6
Compiling net2 v0.2.33
Compiling thread_local v0.3.6
Compiling cmake v0.1.35
Compiling eth-secp256k1 v0.5.7 (https://github.com/paritytech/rust-secp256k1#ccc06e74)
Compiling rand_core v0.2.2
Compiling base64 v0.6.0
Compiling parity-wasm v0.31.3
Compiling base64 v0.9.3
Compiling regex-syntax v0.5.6
Compiling regex-syntax v0.6.2
Compiling unicase v2.2.0
Compiling memchr v2.1.1
Compiling unicase v1.4.2
Compiling crossbeam-epoch v0.5.2
Compiling lock_api v0.1.4
Compiling bytes v0.4.10
Compiling crossbeam-epoch v0.3.1
Compiling log v0.3.9
Compiling trace-time v0.1.1
Compiling stats v0.1.0 (/home/eclassic/nodes/parity-ethereum-2.1.4/util/stats)
Compiling hidapi v0.3.1 (https://github.com/paritytech/hidapi-rs#d4d32376)
Compiling rand v0.5.5
Compiling mio v0.6.16
Compiling tokio-executor v0.1.5
error: failed to run custom build command for hidapi v0.3.1 (https://github.com/paritytech/hidapi-rs#d4d32376)
process didn't exit successfully: /home/eclassic/nodes/parity-ethereum-2.1.4/target/release/build/hidapi-7b8e690a779853db/build-script-build (exit code: 101)
--- stdout
TARGET = Some("x86_64-unknown-linux-gnu")
OPT_LEVEL = Some("3")
HOST = Some("x86_64-unknown-linux-gnu")
CC_x86_64-unknown-linux-gnu = None
CC_x86_64_unknown_linux_gnu = None
HOST_CC = None
CC = None
CFLAGS_x86_64-unknown-linux-gnu = None
CFLAGS_x86_64_unknown_linux_gnu = None
HOST_CFLAGS = None
CFLAGS = None
DEBUG = Some("false")
running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "etc/hidapi/hidapi" "-Wall" "-Wextra" "-o" "/home/eclassic/nodes/parity-ethereum-2.1.4/target/release/build/hidapi-783de682732e743b/out/etc/hidapi/linux/hid.o" "-c" "etc/hidapi/linux/hid.c"
cargo:warning=etc/hidapi/linux/hid.c:44:10: fatal error: libudev.h: No such file or directory
cargo:warning= #include <libudev.h>
cargo:warning= ^~~~~~~~~~~
cargo:warning=compilation terminated.
exit code: 1

--- stderr
thread 'main' panicked at '

Internal error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "etc/hidapi/hidapi" "-Wall" "-Wextra" "-o" "/home/eclassic/nodes/parity-ethereum-2.1.4/target/release/build/hidapi-783de682732e743b/out/etc/hidapi/linux/hid.o" "-c" "etc/hidapi/linux/hid.c" with args "cc" did not execute successfully (status code exit code: 1).

', /home/eclassic/.cargo/registry/src/github.com-1ecc6299db9ec823/cc-1.0.25/src/lib.rs:2260:5
stack backtrace:
0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
1: std::sys_common::backtrace::print
at libstd/sys_common/backtrace.rs:71
at libstd/sys_common/backtrace.rs:59
2: std::panicking::default_hook::{{closure}}
at libstd/panicking.rs:211
3: std::panicking::default_hook
at libstd/panicking.rs:227
4: std::panicking::rust_panic_with_hook
at libstd/panicking.rs:477
5: std::panicking::continue_panic_fmt
at libstd/panicking.rs:391
6: std::panicking::begin_panic_fmt
at libstd/panicking.rs:346
7: cc::fail
8: cc::Build::compile
9: build_script_build::main
10: std::rt::lang_start::{{closure}}
11: std::panicking::try::do_call
at libstd/rt.rs:59
at libstd/panicking.rs:310
12: __rust_maybe_catch_panic
at libpanic_unwind/lib.rs:103
13: std::rt::lang_start_internal
at libstd/panicking.rs:289
at libstd/panic.rs:392
at libstd/rt.rs:58
14: main
15: __libc_start_main
16: _start

warning: build failed, waiting for other jobs to finish...
error: build failed

@niklasad1
Copy link
Collaborator

@Laziemo
Have you installed libudev-dev? libudev.h is not in your path

@i5hi
Copy link

i5hi commented Nov 7, 2018

Cheers @niklasad1 !
@joshua-mir helped figure this in another post.
Thanks for the reply!

@Tbaut Tbaut mentioned this pull request Nov 13, 2018
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation Fault on macOS 10.13.2 at start when enumerating hardware wallets
5 participants