This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
remove util-error #9054
Merged
remove util-error #9054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
dvdplm
approved these changes
Jul 5, 2018
niklasad1
reviewed
Jul 5, 2018
ethcore/src/client/config.rs
Outdated
| @@ -152,7 +152,7 @@ impl Default for ClientConfig { | |||
| } | |||
| #[cfg(test)] | |||
| mod test { | |||
| use super::{DatabaseCompactionProfile, Mode}; | |||
| use super::{DatabaseCompactionProfile}; | |||
niklasad1
reviewed
Jul 5, 2018
ethcore/src/client/error.rs
Outdated
| @@ -24,7 +24,7 @@ pub enum Error { | |||
| /// TrieDB-related error. | |||
| Trie(TrieError), | |||
| /// Util error | |||
There was a problem hiding this comment.
s/Util error/Io error?
niklasad1
approved these changes
Jul 6, 2018
niklasad1
added
the
A6-mustntgrumble 💦
debris
added
A0-pleasereview 🤓
niklasad1
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Jul 6, 2018
* master: remove util-error (#9054)
ordian
added a commit
to ordian/parity
that referenced
this pull request
Jul 9, 2018
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: docs: add changelog for 1.10.9 stable and 1.11.6 beta (openethereum#9069) Enable test in `miner/pool/test` (openethereum#9072) fetch: replace futures-timer with tokio-timer (openethereum#9066) remove util-error (openethereum#9054)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies error handling in
journaldband fixes misuses ofUtilErrorin other modules