Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ethcore: fix compilation when using slow-blocks or evm-debug features #8936

Merged
merged 2 commits into from
Jun 22, 2018
Merged

ethcore: fix compilation when using slow-blocks or evm-debug features #8936

merged 2 commits into from
Jun 22, 2018

Conversation

andresilva
Copy link
Contributor

No description provided.

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jun 20, 2018
@andresilva andresilva changed the title ethcore: fix compilation when slow-blocks feature is enabled ethcore: fix compilation when using slow-blocks or evm-debug features Jun 20, 2018
@5chdn 5chdn added this to the 1.12 milestone Jun 21, 2018
svyatonik
svyatonik approved these changes Jun 21, 2018
View reviewed changes
Copy link
Collaborator

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fixes the build (checked)

@svyatonik svyatonik added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 21, 2018
@debris debris merged commit a6d6adc into master Jun 22, 2018
@debris debris deleted the andre/fix-feature-slow-blocks branch June 22, 2018 09:00
dvdplm added a commit that referenced this pull request Jun 22, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
3e85645 
* master:
  rpc: cap gas limit of local calls (#8943)
  docs: update changelogs (#8931)
  ethcore: fix compilation when using slow-blocks or evm-debug features (#8936)
  fixed blooms dir creation (#8941)
  Update hardcoded headers (#8925)
ordian added a commit to ordian/parity that referenced this pull request Jun 27, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
be121f2 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  deps: bump fs-swap (openethereum#8953)
  Eliminate some more `transmute()` (openethereum#8879)
  Restrict vault.json permssion to owner and using random suffix for temp vault.json file (openethereum#8932)
  print SS.self_public when starting SS node (openethereum#8949)
  scripts: minor improvements (openethereum#8930)
  rpc: cap gas limit of local calls (openethereum#8943)
  docs: update changelogs (openethereum#8931)
  ethcore: fix compilation when using slow-blocks or evm-debug features (openethereum#8936)
  fixed blooms dir creation (openethereum#8941)
  Update hardcoded headers (openethereum#8925)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debris debris debris approved these changes

@svyatonik svyatonik svyatonik approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
4 participants
@andresilva @svyatonik @debris @5chdn