added from and to to Receipt #8756
Conversation
|
Your node is most probably not synced. You should start parity with the |
|
@Tbaut thanks for the explanation. Running into more issues: installed parity-ui. starting parity in the following way: then in parity-ui project: npm start when i route to localhost:3000 i get a loading screen: |
|
Never saw that. Could you install it with the binaries? |
5chdn
added
A0-pleasereview 🤓
|
commenting for gitcoin tracking - the issue is almost done just working out the failing tests |
ab320012
force-pushed
the
master
branch
11 times, most recently
from
fcd624a
to
0cf0e0d
Compare
|
Thanks for the update @ab320012! Snoozed Gitcoin Bot 👍 |
|
@tomusdrw LGTM, this doesn't seem to introduce that second DB read you were talking about, could you please give this a look? |
There was a problem hiding this comment.
Yeah it seems that we are doing multiple reads anyway to figure out the transaction location. Looks good to me, but note that the fields are missing again in "the spec":
https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_gettransactionreceipt
| @@ -157,6 +157,10 @@ pub struct LocalizedReceipt { | |||
| pub log_bloom: Bloom, | |||
| /// Transaction outcome. | |||
| pub outcome: TransactionOutcome, | |||
| /// Receiver address | |||
| pub to: Option<H160>, | |||
There was a problem hiding this comment.
Note we now have:
contract_address: Option<_>,
to: Option<_>,
and exactly one of the two will be Some for every transaction.
Just making sure that what's speced.
|
@tomusdrw Actually, I see what the problem is, the documentation itself is really inconsistent. There's: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_gettransactionreceipt That includes it, but this could be interpreted as the javascript library should be returning the fields on its own (this is obviously not how it works though). I'm actually not sure what the right thing to do here is. |
|
Why not try to update the docs for eth get transaction receipt in ethereum json RPC as it's out of sync with reality edit: |
5chdn
added
A8-looksgood 🦄
|
Need a PR for the wiki too |
* master: Fix subcrate test compile (#8862) network-devp2p: downgrade logging to debug, add target (#8784) Clearing up a comment about the prefix for signing (#8828) Disable parallel verification and skip verifiying already imported txs. (#8834) devp2p: Move UDP socket handling from Discovery to Host. (#8790) Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803) Specify critical release flag per network (#8821) Fix `deadlock_detection` feature branch compilation (#8824) Use system allocator when profiling memory (#8831) added from and to to Receipt (#8756)
…rp_sync_on_light_client * 'master' of https://github.com/paritytech/parity: Fix `deadlock_detection` feature branch compilation (openethereum#8824) Use system allocator when profiling memory (openethereum#8831) added from and to to Receipt (openethereum#8756)
#6948
Opening a PR to track the issue.
I am having some issues testing this. After following initial set up for macos x I start parity and then call with the method eth_getTransactionReceipt; with any transaction it returns a null result
curl -X POST localhost:8545 -H 'content-type: application/json'
-d '{
"jsonrpc": "2.0",
"method": "eth_getTransactionReceipt",
"params": ["0x60a37c38327d3f3b2cace6ad89546895bf49c1fb6c70a4b23c9027967232ecb8"],
"id": 9
}'
=>
{"jsonrpc":"2.0","result":null,"id":1}
I am thinking its a config issue not sure if anyone can assist.