Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Disable hardware-wallets on platforms that don't support libusb #8464

Merged
merged 8 commits into from
Jun 26, 2018
Merged

Disable hardware-wallets on platforms that don't support libusb #8464

merged 8 commits into from
Jun 26, 2018
+184 −39

Commits on Jun 22, 2018

  1. disable hardware-wallets that don't support libusb

    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    5ab6325 View commit details
    Browse the repository at this point in the history

  2. address grumbles

    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    9dbf0d9 View commit details
    Browse the repository at this point in the history

  3. nits

    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    ee51d6d View commit details
    Browse the repository at this point in the history

  4. Refactor to get rid off as much annotations asap 

    * Might consume slight more memory than pure conditional compilation
flags
    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    52cef2d View commit details
    Browse the repository at this point in the history

  5. formatting nits

    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    3156280 View commit details
    Browse the repository at this point in the history

  6. Enable libusb for android 

    * Tested by it compiling succesfully with `cargo build --target=armv7--linux-androideabi`
* The binary is ~66 MB

```bash
$ size
size target/armv7-linux-androideabi/release/parity
text    	data     	bss     	dec     	hex 		filename
50676230        416200   	31456 		51123886        30c16ae 	target/armv7-linux-androideabi/release/parity
```
    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    950a54a View commit details
    Browse the repository at this point in the history

  7. Move all fake-hardware-wallet to its own crate 

    * Removes some conditional compilation flags
* Introduces `fake-hardware-wallet` crate
    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    6548566 View commit details
    Browse the repository at this point in the history

  8. return error if no hardware wallets are found

    @niklasad1
    niklasad1 committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    2011226 View commit details
    Browse the repository at this point in the history