Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Return null number for pending block in eth_getBlockByNumber #8281

Merged
merged 5 commits into from
Apr 2, 2018
Merged

Return null number for pending block in eth_getBlockByNumber #8281

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ed3b65
Return null number for pending block in eth_getBlockByNumber
sorpaas Mar 31, 2018
d409966
Inline false in client_query
sorpaas Mar 31, 2018
0ee2ac1
block hash for pending should be null
sorpaas Mar 31, 2018
a7ceb29
logsBloom should be null for pending blocks
sorpaas Mar 31, 2018
96e2123
Fix test due to logsBloom type change
sorpaas Mar 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions rpc/src/v1/impls/eth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM, T: StateInfo + 'static> EthClient<C, SN, S
fn rich_block(&self, id: BlockNumberOrId, include_txs: bool) -> Result<Option<RichBlock>> {
let client = &self.client;

let client_query = |id| (client.block(id), client.block_total_difficulty(id), client.block_extra_info(id));
let client_query = |id, is_pending| (client.block(id), client.block_total_difficulty(id), client.block_extra_info(id), is_pending);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just inline false here, no point to pass is_pending

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops right.


let (block, difficulty, extra) = match id {
let (block, difficulty, extra, is_pending) = match id {
BlockNumberOrId::Number(BlockNumber::Pending) => {
let info = self.client.chain_info();
let pending_block = self.miner.pending_block(info.best_block_number);
Expand All @@ -199,7 +199,7 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM, T: StateInfo + 'static> EthClient<C, SN, S

let extra = pending_block.as_ref().map(|b| self.client.engine().extra_info(&b.header));

(pending_block.map(|b| encoded::Block::new(b.rlp_bytes(Seal::Without))), Some(difficulty), extra)
(pending_block.map(|b| encoded::Block::new(b.rlp_bytes(Seal::Without))), Some(difficulty), extra, true)
},

BlockNumberOrId::Number(num) => {
Expand All @@ -210,10 +210,10 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM, T: StateInfo + 'static> EthClient<C, SN, S
BlockNumber::Pending => unreachable!(), // Already covered
};

client_query(id)
client_query(id, false)
},

BlockNumberOrId::Id(id) => client_query(id),
BlockNumberOrId::Id(id) => client_query(id, false),
};

match (block, difficulty) {
Expand All @@ -230,7 +230,10 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM, T: StateInfo + 'static> EthClient<C, SN, S
state_root: view.state_root().into(),
transactions_root: view.transactions_root().into(),
receipts_root: view.receipts_root().into(),
number: Some(view.number().into()),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the same spec hash should be null as well.

number: match is_pending {
true => None,
false => Some(view.number().into()),
},
gas_used: view.gas_used().into(),
gas_limit: view.gas_limit().into(),
logs_bloom: view.log_bloom().into(),
Expand Down