Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add test for ethstore-cli, fixes #8027 #8187

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 22, 2018

reopened #8107

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 22, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 22, 2018
@debris debris added the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Mar 23, 2018
@debris
Copy link
Collaborator Author

debris commented Mar 23, 2018

lol, idk why it keeps failing... I rebased and put it on a different branch and the result is the same... how is that possible? @paritytech/ci is it possible for you to check if there is something cached in this build?

In the logs I can see

�[0Ksection_start:1521687819:restore_cache
�[0K�[32;1mChecking cache for test-pr-8187-2...�[0;m
�[32;1mSuccessfully extracted cache�[0;m
section_end:1521687821:restore_cache

but idk what it means

@izgzhen
Copy link

izgzhen commented Mar 24, 2018

I cloud actually produce similar error on my machine:

error: the crate `tiny_keccak` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind`

error: the crate `ethereum_types` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind`

error: the crate `ethbloom` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind`

error: the crate `ethereum_types_serialize` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind`

error: aborting due to 4 previous errors

error: Could not compile `ethabi-derive`.
warning: build failed, waiting for other jobs to finish...
error: build failed

by running cargo build on top-level.

@izgzhen
Copy link

izgzhen commented Mar 24, 2018

But I can't reproduce it deterministically by repeating the same steps

@izgzhen
Copy link

izgzhen commented Mar 26, 2018

There is a hint in https://github.com/paritytech/parity#build-from-source. Could it be caused by CI cache?

@General-Beck
Copy link
Contributor

cargo check and next cargo test

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. labels Mar 28, 2018
@General-Beck General-Beck merged commit 6e49ff1 into master Mar 28, 2018
@General-Beck General-Beck deleted the ethstore-cli-test2 branch March 28, 2018 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants