This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
CI: Fix cargo cache #7968
Merged
CI: Fix cargo cache #7968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5chdn
added
A0-pleasereview 🤓
debris
reviewed
Feb 22, 2018
scripts/gitlab-build.sh
Outdated
| @@ -48,6 +48,8 @@ set_env_win () { | |||
| echo "@ signtool sign /f "\%"1 /p "\%"2 /tr http://timestamp.comodoca.com /du https://parity.io "\%"3" > sign.cmd | |||
| } | |||
| build () { | |||
| echo "Remove index" | |||
| rm -rf cargo/registry/index/*. | |||
There was a problem hiding this comment.
I guess you meant, .cargo/registry/index? That's a terrible idea! Cargo will have to redownload it's crates index and cargo builds may interfere with each.
There was a problem hiding this comment.
Cargo cache is in cargo/ #7921: https://github.com/paritytech/parity/pull/7921/files
The path "is correct", but I can't evaluate if this is the correct way to address this. Problem is that windows builds fail due to a build lock even though there is no other build running.
https://gitlab.parity.io/parity/parity/-/jobs/80511
Please advise :)
There was a problem hiding this comment.
@General-Beck Let's wrap this in the conditional if [[ "windows" = $IDENT ]] for now?
I guess the actual root cause is our cache key selection, but I would do that as a part of enhancing the #7988
There was a problem hiding this comment.
@5chdn I believe this is not a correct way of addressing the problem
debris
added
A4-gotissues 💥
5chdn
added
B0-patch
A0-pleasereview 🤓
kirushik
suggested changes
Mar 1, 2018
scripts/gitlab-build.sh
Outdated
| @@ -48,6 +48,8 @@ set_env_win () { | |||
| echo "@ signtool sign /f "\%"1 /p "\%"2 /tr http://timestamp.comodoca.com /du https://parity.io "\%"3" > sign.cmd | |||
| } | |||
| build () { | |||
| echo "Remove index" | |||
| rm -rf cargo/registry/index/*. | |||
There was a problem hiding this comment.
@General-Beck Let's wrap this in the conditional if [[ "windows" = $IDENT ]] for now?
I guess the actual root cause is our cache key selection, but I would do that as a part of enhancing the #7988
debris
added
A4-gotissues 💥
kirushik
approved these changes
Mar 1, 2018
debris
removed
the
A4-gotissues 💥
debris
approved these changes
Mar 1, 2018
5chdn
pushed a commit
that referenced
this pull request
Mar 3, 2018
* Fix cache Blocking waiting for file lock on the registry index * Only clean locked cargo cache on windows
5chdn
pushed a commit
that referenced
this pull request
Mar 5, 2018
* Fix cache Blocking waiting for file lock on the registry index * Only clean locked cargo cache on windows
Merged
5chdn
pushed a commit
that referenced
this pull request
Mar 5, 2018
* Fix cache Blocking waiting for file lock on the registry index * Only clean locked cargo cache on windows
Merged
tomusdrw
pushed a commit
that referenced
this pull request
Mar 14, 2018
* CI: Fix cargo cache (#7968) * Fix cache Blocking waiting for file lock on the registry index * Only clean locked cargo cache on windows * fixed ethstore sign (#8026) * fixed parsing ethash seals and verify_block_undordered (#8031) * fix for verify_block_basic crashing on invalid transaction rlp (#8032) * fix cache & snapcraft CI build (#8052) after successful testing it is necessary to port in a ```beta``` and ```stable``` * Add MCIP-6 Byzyantium transition to Musicoin spec (#7841) * Add test chain spec for musicoin byzantium testnet * Add MCIP-6 Byzyantium transition to Musicoin spec * Update mcip6_byz.json * ethcore: update musicoin byzantium block number * ethcore: update musicoin byzantium block number * ethcore: update musicoin bootnodes * Update musicoin.json * Update musicoin.json * More bootnodes.
tomusdrw
pushed a commit
that referenced
this pull request
Mar 14, 2018
* CI: Fix cargo cache (#7968) * Fix cache Blocking waiting for file lock on the registry index * Only clean locked cargo cache on windows * fixed ethstore sign (#8026) * fix cache & snapcraft CI build (#8052) after successful testing it is necessary to port in a ```beta``` and ```stable``` * Add MCIP-6 Byzyantium transition to Musicoin spec (#7841) * Add test chain spec for musicoin byzantium testnet * Add MCIP-6 Byzyantium transition to Musicoin spec * Update mcip6_byz.json * ethcore: update musicoin byzantium block number * ethcore: update musicoin byzantium block number * ethcore: update musicoin bootnodes * Update musicoin.json * Update musicoin.json * More bootnodes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking waiting for file lock on the registry index