This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Light client: randomize the peer we dispatch requests to #7844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
Feb 8, 2018
It looks like @tomaka signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
debris
approved these changes
Feb 8, 2018
@arkpar can you confirm that it solves our problem? |
Curious myself, I'm syncing with the patch as we speak. |
rphmeier
approved these changes
Feb 8, 2018
debris
added
A8-looksgood 🦄
Pull request is reviewed well.
A0-pleasereview 🤓
Pull request needs code review.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Feb 8, 2018
Confirming this does not solve #6319 yet - unfortunately :) But we can proceed from here. |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #6319
The issue seems to be caused by non-responsive peers clogging the pipeline.
While this PR doesn't fix the issue entirely, it greatly mitigates it by randomly choosing a peer to query every time we do a request.
Even if we ignore #6319, I think this is a desirable change.