Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

CSP hardening #7621

Merged
merged 2 commits into from
Jan 19, 2018
Merged

CSP hardening #7621

merged 2 commits into from
Jan 19, 2018

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M7-ui labels Jan 18, 2018
@5chdn 5chdn added the B0-patch label Jan 18, 2018
@5chdn
Copy link
Contributor

5chdn commented Jan 18, 2018

Please make sure all "fixes" receive a patch label.

@jacogr
Copy link
Contributor

jacogr commented Jan 18, 2018

LGTM, also tested it locally earlier today.

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 19, 2018
@debris debris merged commit 58645d3 into master Jan 19, 2018
@debris debris deleted the td-csp-harden branch January 19, 2018 09:38
@5chdn 5chdn added this to the 1.10 milestone Jan 19, 2018
debris pushed a commit that referenced this pull request Jan 22, 2018
@tomusdrw @debris
Hardening of CSP (#7621)
2546af2
@debris debris mentioned this pull request Jan 22, 2018
Merged
5chdn pushed a commit that referenced this pull request Jan 23, 2018
@debris @5chdn
Backports to beta (#7660)
fa6a0a6 
* Improve handling of RocksDB corruption (#7630)

* kvdb-rocksdb: update rust-rocksdb version

* kvdb-rocksdb: mark corruptions and attempt repair on db open

* kvdb-rocksdb: better corruption detection on open

* kvdb-rocksdb: add corruption_file_name const

* kvdb-rocksdb: rename mark_corruption to check_for_corruption

* Hardening of CSP (#7621)

* Fixed delegatecall's from/to (#7568)

* Fixed delegatecall's from/to, closes #7166

* added tests for delegatecall traces, #7167

* Light client RPCs (#7603)

* Implement registrar.

* Implement eth_getCode

* Don't wait for providers.

* Don't wait for providers.

* Fix linting and wasm tests.

* Problem: AttachedProtocols don't get registered (#7610)

I was investigating issues I am having with Whisper support. I've
enabled Whisper on a custom test network and inserted traces into
Whisper handler implementation (Network<T> and NetworkProtocolHandler
for Network<T>) and I noticed that the handler was never invoked.

After further research on this matter, I found out that
AttachedProtocol's register function does nothing:
https://github.com/paritytech/parity/blob/master/sync/src/api.rs#L172
but there was an implementation originally:
99075ad#diff-5212acb6bcea60e9804ba7b50f6fe6ec and it did the actual
expected logic of registering the protocol in the NetworkService.

However, as of 16d84f8#diff-5212acb6bcea60e9804ba7b50f6fe6ec ("finished
removing ipc") this implementation is gone and only the no-op function
is left.

Which leads me to a conclusion that in fact Whisper's handler never gets
registered in the service and therefore two nodes won't communicate
using it.

Solution: Resurrect original non-empty `AttachedProtocols.register`
implementation

Resolves #7566

* Fix Temporarily Invalid blocks handling (#7613)

* Handle temporarily invalid blocks in sync.

* Fix tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debris debris debris approved these changes

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @5chdn @jacogr @debris