This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add RPC eth_chainId for querying the current blockchain chain ID #6329
Merged
Commits on Aug 18, 2017
-
Add RPC eth_chainId for querying the current blockchain chain ID
Currently although we can use `net_version` RPC call to get the current network ID, there's no RPC for querying the chain ID. This makes it impossible to determine the current actual blockchain using the RPC. An ETH/ETC client can accidentally connect to an ETC/ETH RPC endpoint without knowing it unless it tries to sign a transaction or it fetch a transaction that is known to have signed with a chain ID. This has since caused trouble for application developers, such as MetaMask, to add multi-chain support. The same RPC endpoint is also about to be merged for ETC's go-ethereum: ethereumproject/go-ethereum#336
Configuration menu - View commit details
-
Copy full SHA for 6995f05 - Browse repository at this point
Copy the full SHA 6995f05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f8f215 - Browse repository at this point
Copy the full SHA 7f8f215View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb354fc - Browse repository at this point
Copy the full SHA fb354fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87787d2 - Browse repository at this point
Copy the full SHA 87787d2View commit details
Commits on Aug 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c3cfa16 - Browse repository at this point
Copy the full SHA c3cfa16View commit details
Commits on Sep 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9bea238 - Browse repository at this point
Copy the full SHA 9bea238View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29dcabb - Browse repository at this point
Copy the full SHA 29dcabbView commit details
Commits on Sep 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 64e2256 - Browse repository at this point
Copy the full SHA 64e2256View commit details -
Use U256 to return chainId and fix for master
u64 returns decimal integer, and there seems to be no type called U64. So here I use U256 to return the hex integer.
Configuration menu - View commit details
-
Copy full SHA for cf8e189 - Browse repository at this point
Copy the full SHA cf8e189View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8beb21 - Browse repository at this point
Copy the full SHA b8beb21View commit details
Commits on Sep 18, 2017
-
Change both parity_chainId and transaction::chainId to use U64
This makes it consistent that all chain ids returned are hex string.
Configuration menu - View commit details
-
Copy full SHA for 4da73e9 - Browse repository at this point
Copy the full SHA 4da73e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1831fff - Browse repository at this point
Copy the full SHA 1831fffView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.