-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
[ci:skip]
@@ -73,6 +75,7 @@ impl From<ethjson::spec::EthashParams> for EthashParams { | |||
difficulty_hardfork_transition: p.difficulty_hardfork_transition.map_or(0x7fffffffffffffff, Into::into), | |||
difficulty_hardfork_bound_divisor: p.difficulty_hardfork_bound_divisor.map_or(p.difficulty_bound_divisor.into(), Into::into), | |||
bomb_defuse_transition: p.bomb_defuse_transition.map_or(0x7fffffffffffffff, Into::into), | |||
bad_gas_compatibility_mode_limit: p.bad_gas_compatibility_mode_limit.map_or(0, Into::into), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break all private chains after upgrade. Maybe leave it disabled by default and just update sample and documentation specs to enable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. the thing is that if we don't default it to 'on', then all private chains will be defaulting to using a broken protocol and run the risk of being internally DoSed.
we can print a warning to ensure they know what went wrong.
Looks fine, I think I would get rid of
Looks good otherwise 👍 |
As defined in ethereum/EIPs#150 and implemented in ethereum/pyethereum@6d7e28a .
Still TODO:
suicide_to_new_account_cost
.@tomusdrw please review.