Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Handle RLP to string UTF-8 decoding errors #2217

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Handle RLP to string UTF-8 decoding errors #2217

merged 1 commit into from
Sep 21, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Sep 21, 2016

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Sep 21, 2016
@arkpar
Copy link
Collaborator Author

arkpar commented Sep 21, 2016

Potentially fixes #2063

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 21, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 85.275% when pulling a3a9b8c on rlp-utf8-fix into 93f82a1 on master.

@gavofyork gavofyork merged commit 0688716 into master Sep 21, 2016
@gavofyork gavofyork deleted the rlp-utf8-fix branch September 21, 2016 10:59
gavofyork pushed a commit that referenced this pull request Sep 23, 2016
* Handle RLP to string UTF-8 decoding errors (#2217)

* pending transactions
tomusdrw added a commit that referenced this pull request Sep 23, 2016
* Handle RLP to string UTF-8 decoding errors (#2217)

* pending transactions

Conflicts:
	rpc/src/v1/impls/ethcore.rs
	rpc/src/v1/traits/ethcore.rs
gavofyork pushed a commit that referenced this pull request Sep 25, 2016
* Handle RLP to string UTF-8 decoding errors (#2217)

* Penalize transactions with gas above gas limit

* Avoid penalizing legit transactions

* saturating not overflowing

* Remove crufty code

* Introduce gas price ordering.

* Gas before gas-price, as long as the minimum price is met.

* saturating add
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants