This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
DAO hard-fork #1483
Merged
DAO hard-fork #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-inprogress ⏳
gavofyork
added
A1-onice 🌨
gavofyork
added
A0-pleasereview 🤓
|
Since DAO params are optional it would be nice to remove them from morden and other unrelated spec files |
| @@ -119,10 +128,27 @@ impl Engine for Ethash { | |||
| (header.gas_used * 6.into() / 5.into()) / bound_divisor)) | |||
| } | |||
| }; | |||
| if header.number >= self.ethash_params.dao_hardfork_transition && | |||
| header.number <= self.ethash_params.dao_hardfork_transition + 9 { | |||
There was a problem hiding this comment.
Might cause an overflow panic if header number is 0xffffffffffffffffff. Is it guaranteed that no invalid headers are input to this function?
There was a problem hiding this comment.
yeah that's a bit fragile in any case. will just use a smaller number :)
arkpar
added
A5-grumble 🔥
gavofyork
added
A0-pleasereview 🤓
gavofyork
added
A1-onice 🌨
Change the mining default to release only on own transactions.
gavofyork
added
A8-looksgood 🦄
5chdn
added
M4-core ⛓
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the specification given on https://gist.github.com/gavofyork/856b27cf1a482585692359e28d3ae4cb