Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix compile warnings #10993

Merged
merged 2 commits into from
Aug 27, 2019
Merged

fix compile warnings #10993

merged 2 commits into from
Aug 27, 2019

Conversation

niklasad1
Copy link
Collaborator

This PR eliminates a bunch of compiler warnings most of them were bare-trait-object i.e., replaced by dyn trait.

Tried cargo fix first but then I fixed the rest of them manually

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 27, 2019
@ordian ordian added this to the 2.7 milestone Aug 27, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 27, 2019
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

@dvdplm dvdplm added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Aug 27, 2019
rpc/src/lib.rs Show resolved Hide resolved
@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Aug 27, 2019
@ordian ordian merged commit dab2a6b into master Aug 27, 2019
@ordian ordian deleted the na-fix-warns-v2 branch August 27, 2019 15:29
dvdplm added a commit that referenced this pull request Aug 27, 2019
dvdplm added a commit that referenced this pull request Aug 28, 2019
* master:
  Make ClientIoMessage generic over the Client (#10981)
  bump spin to 0.5.2 (#10996)
  fix compile warnings (#10993)
  Fix compilation on recent nightlies (#10991)
  [ipfs] Convert to edition 2018 (#10979)
dvdplm added a commit that referenced this pull request Aug 28, 2019
…/eip-1884-reprice-trie-size-dependent-ops

* dp/feature/eip-1344-add-ChainID-opcode:
  more merge fallout
  Update ethcore/vm/src/schedule.rs
  Fix a few warnings
  merge conflict error
  Make ClientIoMessage generic over the Client (#10981)
  bump spin to 0.5.2 (#10996)
  fix compile warnings (#10993)
  Fix compilation on recent nightlies (#10991)
  [ipfs] Convert to edition 2018 (#10979)
ordian added a commit to ordian/parity that referenced this pull request Aug 29, 2019
* master:
  EIP 1884 Re-pricing of trie-size dependent operations (openethereum#10992)
  xDai chain support and nodes list update (openethereum#10989)
  [trace] check mem diff within range (openethereum#11002)
  EIP-1344 Add CHAINID op-code (openethereum#10983)
  Make ClientIoMessage generic over the Client (openethereum#10981)
  bump spin to 0.5.2 (openethereum#10996)
  fix compile warnings (openethereum#10993)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants