Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Move the substate module into ethcore/executive #10867

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Move the substate module into ethcore/executive #10867

merged 4 commits into from
Jul 10, 2019

Conversation

debris
Copy link
Collaborator

@debris debris commented Jul 8, 2019

changes

  • account-state does not depend on the vm and evm
  • fn cleanup_mode is not a part of Substate implementation
  • fixed several warnings

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 8, 2019
@debris debris requested a review from dvdplm July 8, 2019 17:18
dvdplm
dvdplm approved these changes Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a unit test for cleanup_mode()?

@dvdplm dvdplm changed the title substate Move the substate module into ethcore/executive Jul 8, 2019
@dvdplm dvdplm added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 8, 2019
@ordian ordian added this to the 2.7 milestone Jul 10, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Jul 10, 2019
@ordian ordian merged commit 34cdeac into master Jul 10, 2019
@ordian ordian deleted the substate branch July 10, 2019 08:55
dvdplm added a commit that referenced this pull request Jul 11, 2019
@dvdplm
Merge branch 'master' into dp/chore/extract-state-followup
9cb241d 
* master:
  Docker images renaming (#10863)
  Move the substate module into ethcore/executive (#10867)
  Run cargo fix on a few of the worst offenders (#10854)
  removed redundant fork choice abstraction (#10849)
  Extract state-db from ethcore (#10858)
dvdplm added a commit that referenced this pull request Jul 12, 2019
@dvdplm
Merge branch 'master' into dp/chore/move-more-types-out-of-ethcore
8e88f2e 
* master:
  whisper is no longer a part of parity-ethereum repo (#10855)
  [ethash] remove mem::uninitialized (#10861)
  Docker images renaming (#10863)
  Move the substate module into ethcore/executive (#10867)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seunlanlege seunlanlege seunlanlege approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@debris @dvdplm @seunlanlege @ordian