Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Improve logging and cleanup in miner around block sealing #10745

Merged
merged 59 commits into from
Jul 4, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jun 13, 2019

Builds on #10734

Adds extensive logging around block sealing and does minor cleanup in the miner.

HCastano and others added 30 commits June 10, 2019 12:26
Escalate bad proposer to warning
…when-validators-is-1-or-even

* dp/hc-non-canon-block-logging:
  More readable code
…when-validators-is-1-or-even

* dp/hc-non-canon-block-logging:
  Wording
  Extensive logging on unexpected non-canonical hash
…hub.com:paritytech/parity-ethereum into dp/chore/aura-warn-when-validators-is-1-or-even

* 'dp/chore/aura-warn-when-validators-is-1-or-even' of github.com:paritytech/parity-ethereum:
  Update ethcore/blockchain/src/blockchain.rs
…-even

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
…anager

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
…p/chore/aura-log-validator-set-in-epoch-manager

* dp/chore/aura-warn-when-validators-is-1-or-even:
  Improved logging, address grumbles
  Update ethcore/blockchain/src/blockchain.rs
…thub.com:paritytech/parity-ethereum into dp/chore/aura-log-validator-set-in-epoch-manager

* 'dp/chore/aura-log-validator-set-in-epoch-manager' of github.com:paritytech/parity-ethereum:
  Update ethcore/src/engines/validator_set/simple_list.rs
Don't require node to be part of the validator set to report malicious behaviour
Move check for parent_step == step for clarity&efficiency
Remove dead code for Seal::Proposal
dvdplm added 16 commits June 24, 2019 16:35
…anager

* master:
  Treat empty account the same as non-exist accounts in EIP-1052 (#10775)
  docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652)
  Move Engine::register_client to be before other I/O handler registration (#10767)
…dp/fix/prevent-building-block-on-top-of-same-parent

* dp/chore/aura-log-validator-set-in-epoch-manager:
  remove dead code
  Treat empty account the same as non-exist accounts in EIP-1052 (#10775)
  docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652)
  cleanup
  On second thought non-validators are allowed to report
  Move Engine::register_client to be before other I/O handler registration (#10767)
  cleanup
  Print warnings when using dangerous settings for ValidatorSet (#10733)
  ethcore/res: activate atlantis classic hf on block 8772000 (#10766)
  refactor: Fix indentation (#10740)
  Updated Bn128PairingImpl to use optimized batch pairing  (#10765)
  fix: aura don't add `SystemTime::now()` (#10720)
  Initialize private tx logger only if private tx functionality is enabled (#10758)
  Remove unused code (#10762)
  Remove calls to heapsize (#10432)
…me-parent

* master:
  Log validator set changes in EpochManager (#10734)
…me-parent

* master: (24 commits)
  cargo update -p smallvec (#10822)
  replace memzero with zeroize crate (#10816)
  Don't repeat the logic from Default impl (#10813)
  removed additional_params method (#10818)
  Add Constantinople eips to the dev (instant_seal) config (#10809)
  removed redundant fmt::Display implementations (#10806)
  revert changes to .gitlab-ci.yml (#10807)
  Add filtering capability to `parity_pendingTransactions` (issue 8269) (#10506)
  removed EthEngine alias (#10805)
  wait a bit longer in should_check_status_of_request_when_its_resolved (#10808)
  Do not drop the peer with None difficulty (#10772)
  ethcore-bloom-journal updated to 2018 (#10804)
  ethcore-light uses bincode 1.1 (#10798)
  Fix a few typos and unused warnings. (#10803)
  updated project to ansi_term 0.11 (#10799)
  added new ropsten-bootnode and removed old one (#10794)
  updated price-info to edition 2018 (#10801)
  ethcore-network-devp2p uses igd 0.9 (#10797)
  updated parity-local-store to edition 2018 and removed redundant Error type (#10800)
  Cleanup unused vm dependencies (#10787)
  ...
…me-parent

* master:
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
  idiomatic changes to PodState (#10834)
  Allow --nat extip:your.host.here.org (#10830)
  When updating the client or when called from RPC, sleep should mean sleep (#10814)
  Remove excessive warning (#10831)
  Fix typo in README.md (#10828)
  ethcore does not use byteorder (#10829)
  Better logging when backfilling ancient blocks fail (#10796)
  depends: Update wordlist to v1.3 (#10823)
@dvdplm dvdplm changed the title Prevent building block on top of same parent Improve logging and cleanup in miner around block sealing Jul 4, 2019
@dvdplm dvdplm marked this pull request as ready for review July 4, 2019 12:21
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 4, 2019
ethcore/src/block.rs Outdated Show resolved Hide resolved
@ordian ordian added this to the 2.6 milestone Jul 4, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 4, 2019
@dvdplm dvdplm merged commit de906d4 into master Jul 4, 2019
@dvdplm dvdplm deleted the dp/fix/prevent-building-block-on-top-of-same-parent branch July 4, 2019 16:03
dvdplm added a commit that referenced this pull request Jul 4, 2019
* master:
  Improve logging and cleanup in miner around block sealing (#10745)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants