Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Delete user_defaults when doing db kill #8550

Closed
stnbu opened this issue May 7, 2018 · 19 comments
Closed

Delete user_defaults when doing db kill #8550

stnbu opened this issue May 7, 2018 · 19 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either
Milestone

Comments

@stnbu
Copy link

stnbu commented May 7, 2018

Before filing a new issue, please provide the following information.

I'm running:

  • Which Parity version?:
Parity/v1.12.0-unstable-e30839e-20180505/x86_64-linux-gnu/rustc1.25.0-dev
  • Which operating system?:
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.4 LTS
Release:        16.04
Codename:       xenial
  • How installed?: via installer / homebrew / binaries / from source

compiled rustc (1.25.dev) --> compiled cargo (0.26) --> compiled parity (git:e30839e85ff74cd5eb087ef19a48d70afd1fd285)

  • Are you fully synchronized?:

Yes. Completely new setup using --config dev

  • Which network are you connected to?: ethereum / ropsten / kovan / ...

built-in dev config

  • Did you try to restart the node?: no / yes

n/a. The problem appears immediately after start

Your issue description goes here below. Try to include actual vs. expected behavior and steps to reproduce the issue.

expected behavior: Export state to file with parity export state foo.txt.

actual behavior: I re-started the node with --fat-db on and still received the error.

I run

parity --config dev --fat-db on

Starting with no db at all

~$ find .
.
./.bash_logout
./.profile
./.bashrc

Even with --fat-db on from the beginning, in another terminal I get:

~$ parity export state foo.txt
This command requires Parity to be synced with --fat-db on.

I notice the word "synced", is that something I need to do in addition to running with --fat-db on from an empty database?

@sorpaas
Copy link
Collaborator

sorpaas commented May 7, 2018

Try parity --config dev export state foo.txt.

@sorpaas sorpaas added the Z1-question 🙋‍♀️ Issue is a question. Closer should answer. label May 7, 2018
@Tbaut
Copy link
Contributor

Tbaut commented May 7, 2018

You probably have to delete the user_default file.
On linux it can be found in the chain directory:

find ~/.local/share/io.parity.ethereum -name "user_defaults"
/home/user/.local/share/io.parity.ethereum/chains/kovan/user_defaults
/home/user/.local/share/io.parity.ethereum/chains/ethereum/user_defaults
/home/user/.local/share/io.parity.ethereum/chains/test/user_defaults
/home/user/.local/share/io.parity.ethereum/chains/DevelopmentChain/user_defaults
/home/user/.local/share/io.parity.ethereum/chains/classic/user_defaults
/home/user/.local/share/io.parity.ethereum/chains/musicoin/user_defaults
/home/user/.local/share/io.parity.ethereum/docker/chains/kovan/user_defaults
/home/user/.local/share/io.parity.ethereum/docker/chains/ethereum/user_defaults
/home/user/.local/share/io.parity.ethereum/docker/chains/test/user_defaults
/home/user/.local/share/io.parity.ethereum/docker/chains/DevelopmentChain/user_defaults

@Tbaut Tbaut added P5-sometimesoon 🌲 Issue is worth doing soon. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. labels May 7, 2018
@Tbaut Tbaut added this to the 1.12 milestone May 7, 2018
@folsen
Copy link
Contributor

folsen commented May 21, 2018

@Tbaut you added the sometimesoon label to this, do you think there's anything to do here? Like automatically fixing the user defaults when changing to fat-db on a dev chain or something? Please elaborate so a dev can pick it up.

@Tbaut
Copy link
Contributor

Tbaut commented May 21, 2018

If my advice solved the problem, then I'd suggest to automatically reset the user_defaults when doing a db kill as it seems not to be the case right now.

@folsen
Copy link
Contributor

folsen commented May 22, 2018

@debris any reason not to delete user_defaults when doing db kill?

@debris
Copy link
Collaborator

debris commented May 22, 2018

no, they should be deleted

@debris debris added the Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. label May 22, 2018
@folsen folsen changed the title with fat-db=on still cannot "export state" fails with fat-db mesage Delete user_defaults when doing db kill May 22, 2018
@Tbaut Tbaut added the Q3-medium A fair chunk of work, not necessarily very hard but not trivial either label Jun 19, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.3 ETH (161.55 USD @ $538.51/ETH) attached to it.

@5chdn 5chdn removed the Z1-question 🙋‍♀️ Issue is a question. Closer should answer. label Jun 24, 2018
@gitcoinbot
Copy link

@pfilippi24 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

3 similar comments
@gitcoinbot
Copy link

@pfilippi24 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@pfilippi24 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@pfilippi24 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Tbaut
Copy link
Contributor

Tbaut commented Jul 6, 2018

@gitcoinbot :)

@gitcoinbot
Copy link

@mttmartin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mttmartin
Copy link
Contributor

I have a PR for this at #9081

@andresilva
Copy link
Contributor

I don't think we should delete the user_defaults. We already have code to handle this properly, whenever we do db kill we set the user_defaults to be considered as "first launch" which gives us the ability to switch on/off fatdb and tracedb afterwards. The issue is that the JSON deserializer is currently not looking at this field. PR #9130 fixes this.

@5chdn 5chdn modified the milestones: 2.0, 2.1 Jul 17, 2018
@gitcoinbot
Copy link

@mttmartin Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.3 ETH (139.34 USD @ $464.46/ETH) has been submitted by:

  1. @mttmartin

@vs77bb please take a look at the submitted work:


@mttmartin
Copy link
Contributor

@vs77bb to remind you, I asked you on slack whether I should stop work or whether you should cancel the bounty, and you said to submit work.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.3 ETH (138.5 USD @ $461.68/ETH) attached to this issue has been approved & issued to @mttmartin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M2-config 📂 Chain specifications and node configurations. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. Q3-medium A fair chunk of work, not necessarily very hard but not trivial either
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants