-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Parity no longer compatible with expanse #7061
Comments
Is expanse no longer maintaining parity compatibility? We should consider removing it then. |
@5chdn is right. we only maintain specs for most chains up to the point that the developers for those chains are willing to maintain them |
Found the changes in here: https://github.com/expanse-org/go-expanse/releases/tag/v1.7.2
Friendly ping to EXP dev @chrisfranko - could you comment on this? Is EXP support in Parity still desired? :) |
Yes we would still love parity support. When making the fork I didnt see where to make the corresponding changes to parity to submit the pr. If you could kindly point me to where i can make the Byzantium changes that would be awesome! |
I think most of the changes can be applied by adjusting the chain spec in https://github.com/paritytech/parity/blob/master/ethcore/res/ethereum/expanse.json I'm not quite understanding the complexity of the changes involved. Did you just enable Byzantium? Is the block target time and reward related to EIP649? If yes, you can use eip649transition and reward, compare: 07c63c1 I'm happy to test if you come up with a chain spec. If there is anything on top of this, it might require additional code. |
Thanks 5chdn ill do this first thing in the AM, holliday stuff had me busy this weekend. ^_^ |
Any news on this? What happens to the coins that were mined after the fork on the old chain using Parity? |
No idea. You can start Expanse Classic 😛 Closing as there is nobody maintaining this anymore. |
@chrisfranko FYI ^ |
Happy to accept a PR with a working integration. For now it's urgent to remove it to avoid users getting stuck on the wrong fork. |
Except there is someone maintaining it and we were waiting on guidance because we updated everything we thought we were supposed to update. |
I'm sorry if this was due to a misunderstanding. Let's keep working on #7146 and I'll try to guide you. |
Thanks. So im pretty sure i got it right in the new commit. What I did was
add a new param to the ethparams struct called EXPIP2 duration time and
transition. Then below, checked to see if block.number > expip2 transition
Then updated the duration limit based on if that variable is true.
…On 3 January 2018 at 17:06, Afri Schoedon ***@***.***> wrote:
I'm sorry if this was due to a misunderstanding. Let's keep working on
#7146 <#7146> and I'll try to
guide you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7061 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADYQsR-_HFXV4B8SocgVXGIeGB5a4rzEks5tG_njgaJpZM4Qe7l3>
.
|
I'm not familiar with compiling rust so I havnt tested it yet, but it looks
right.
On 4 January 2018 at 09:03, Christopher Franko <[email protected]>
wrote:
… Thanks. So im pretty sure i got it right in the new commit. What I did was
add a new param to the ethparams struct called EXPIP2 duration time and
transition. Then below, checked to see if block.number > expip2 transition
Then updated the duration limit based on if that variable is true.
On 3 January 2018 at 17:06, Afri Schoedon ***@***.***>
wrote:
> I'm sorry if this was due to a misunderstanding. Let's keep working on
> #7146 <#7146> and I'll try to
> guide you.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#7061 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADYQsR-_HFXV4B8SocgVXGIeGB5a4rzEks5tG_njgaJpZM4Qe7l3>
> .
>
|
Parity (1.8.2) is no longer compatible with expanse, since it is working on the wrong chain. Expanse forked at block 800’000.
The text was updated successfully, but these errors were encountered: