Remove hash records after 2 rounds instead of 100 steps.

openethereum · Oct 11, 2019 · 8581b8c · 8581b8c
1 parent fd1b547
commit 8581b8c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/ethcore/engines/authority-round/src/lib.rs b/ethcore/engines/authority-round/src/lib.rs
@@ -1401,9 +1401,10 @@ impl Engine for AuthorityRound {
 			self.received_step_hashes.write().insert(received_step_key, new_hash);
 		}
 
-		// Remove hash records older than 100 steps (picked as a reasonable trade-off between memory consumption and fault-tolerance).
-		const SIBLING_MALICE_DETECTION_PERIOD: u64 = 100;
-		let oldest_step = parent_step.saturating_sub(SIBLING_MALICE_DETECTION_PERIOD);
+		// Remove hash records older than two full rounds of steps (picked as a reasonable trade-off between
+		// memory consumption and fault-tolerance).
+		let sibling_malice_detection_period = 2 * validators.count(&parent.hash()) as u64;
+		let oldest_step = parent_step.saturating_sub(sibling_malice_detection_period);
 		if oldest_step > 0 {
 			let mut rsh = self.received_step_hashes.write();
 			let new_rsh = rsh.split_off(&(oldest_step, Address::zero()));