Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Latest binary does not run on macos #401

Closed
amaury1093 opened this issue Feb 4, 2019 · 3 comments
Closed

Latest binary does not run on macos #401

amaury1093 opened this issue Feb 4, 2019 · 3 comments

Comments

@amaury1093
Copy link
Collaborator

amaury1093 commented Feb 4, 2019

After #352, new binaries have been released (see the Draft v0.3.0 in the releases page), but error on launch.

screenshot 2019-02-04 at 16 51 40

Another way to repro: yarn package in the root folder, and open packages/fether-electron/dist/mac/Parity Fether.app

@ltfschoen
Copy link
Contributor

ltfschoen commented Feb 4, 2019

Yes, I should have checked that the binaries build first.
I get the same error when I run

rm -rf node_modules/;
rm yarn.lock;
yarn;
yarn package;
open "./packages/fether-electron/dist/mac/Parity Fether.app"

@ltfschoen
Copy link
Contributor

ltfschoen commented Feb 5, 2019

If I just updated Pino, I still got error. But after I added "ansi-styles": "^3.2.1", to the dependencies it build successfully on macos

screen shot 2019-02-05 at 10 40 08 am

@ltfschoen
Copy link
Contributor

ltfschoen commented Feb 5, 2019

I've been able to resolve the error and build on macos. I've was also able to update all the dependencies in fether-electron to the latest versions (except for pino-multi-stream). But with the latest pino and pino-pretty, it's not logging the pino.info(...'s to stdout when i change the code to const pretty = Pino({ prettyPrint: { colorize: true, outputStream: process.stdout } });, and since I haven't been able to figure out how to retain the functionality of logging to stdout with the latest pino version, I'm just going to leave pino versions as they were, since we just need ansi-styles to resolve the bug.

amaury1093 added a commit that referenced this issue Feb 5, 2019
fix: Fixes #401. Add ansi-styles to fix bug. Update other dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants