-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crypto in flex 3.13 series #283
Merged
bradymiller
merged 7 commits into
openemr:master
from
bradymiller:fix-crypto-flex-3.13-series
Feb 15, 2021
Merged
fix crypto in flex 3.13 series #283
bradymiller
merged 7 commits into
openemr:master
from
bradymiller:fix-crypto-flex-3.13-series
Feb 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yea it has broken alot of stuff...
The new alpine requires the new xdebug so settings need to change. Here is
what I used to get it working for me on localhost
; start xdebug configuration" >> /etc/php7/php.ini
zend_extension=/usr/lib/php7/modules/xdebug.so
xdebug.start_with_request=yes
xdebug.remote_handler=dbgp
xdebug.client_port=9003
xdebug.remote_log=/tmp/xdebug.log
xdebug.mode=debug
xdebug.XDEBUG_SESSION=1
xdebug.remote_host=localhost
xdebug.discover_client_host=true
xdebug.client_host=localhost
Met vriendelijke groet,
Julie
…On Sat, Feb 13, 2021 at 11:41 AM Brady Miller ***@***.***> wrote:
fix crypto in flex 3.13 series
The crypto thing was also breaking in 3.13 series, which is fixed by
adding the rust package manager (cargo)
However, this shoots the docker size through the roof! It increases it by
500 MB (goes from 750MB to 1.25GB)
@jesdynf <https://github.com/jesdynf> , any thoughts on why the size went
crazy (maybe a cache or something). I'm still trying to figure out this
Rust stuff (i also read that ticket which was pretty crazy stuff to
consider the billions of things were broken with the change :) ).
It also adds a lot more time to the build, but can live with that.
------------------------------
You can view, comment on, or merge this pull request online at:
#283
Commit Summary
- fix crypto in flex 3.13 series
File Changes
- *M* docker/openemr/6.1.0/Dockerfile
<https://github.com/openemr/openemr-devops/pull/283/files#diff-797cdb160915b356837452b6728bc06f1bc534b7dc80ce21786fd23f281ef361>
(4)
- *M* docker/openemr/flex-3.13-8/Dockerfile
<https://github.com/openemr/openemr-devops/pull/283/files#diff-26e00c38a7054cb5151cb3c5dd51529d43f3173a1207acb9e5bf6a10d5e07f37>
(4)
- *M* docker/openemr/flex-3.13/Dockerfile
<https://github.com/openemr/openemr-devops/pull/283/files#diff-cfaa2c0b79e96dc76d9b1db3ebb01673455e47f381b370b9aa8d0a24a1f076d3>
(2)
- *M* docker/openemr/flex-edge/Dockerfile
<https://github.com/openemr/openemr-devops/pull/283/files#diff-72097c56de16d77f21e1174d3e02927ef7ae39365a1087d3fedd01555a1b6bd4>
(2)
Patch Links:
- https://github.com/openemr/openemr-devops/pull/283.patch
- https://github.com/openemr/openemr-devops/pull/283.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#283>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHAJ5NVOZGJSCX7MTIK7UDS6ZJNFANCNFSM4XSATAUA>
.
|
@boxlady are you using phpstorm with xdebug hooked up to the development-easy dockers? |
I am :) |
Sorry was sleeping, here are some screenshots of my setup
[image: Screenshot from 2021-02-16 06-51-12.png][image: Screenshot from
2021-02-16 06-51-58.png][image: Screenshot from 2021-02-16 06-55-28.png][image:
Screenshot from 2021-02-16 06-56-51.png]
[image: Screenshot from 2021-02-16 06-57-32.png]This last one is important
- set CLI to the docker image you are using
[image: Screenshot from 2021-02-16 07-21-54.png]
Hope that helps, if you have any questions let me know
Met vriendelijke groet,
Julie Buurman
…On Mon, Feb 15, 2021 at 9:52 PM stephen waite ***@***.***> wrote:
v cool, anything special you had to do inside of phpstorm to configure it
for debug?
[image: Screenshot from 2021-02-15 15-51-54]
<https://user-images.githubusercontent.com/5618372/107991987-c3c9c780-6fa5-11eb-8eb5-33f35873e8a2.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHAJ5KYWXT352MCIWTKXUDS7GCRJANCNFSM4XSATAUA>
.
|
thank you @boxlady , not sure why the images don't appear above |
weird... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix crypto in flex 3.13 series
The crypto thing was also breaking in 3.13 series, which is fixed by adding the rust package manager (cargo)
However, this shoots the docker size through the roof! It increases it by 500 MB (goes from 750MB to 1.25GB)
@jesdynf , any thoughts on why the size went crazy (maybe a cache or something). I'm still trying to figure out this Rust stuff (i also read that ticket which was pretty crazy stuff to consider the billions of things around the world that were instantly broken with the change :) ).
It also adds a lot more time to the build, but can live with that.