Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_types_sparse: Fix syntax error #725

Closed
wants to merge 1 commit into from
+6 −5
Closed

image_types_sparse: Fix syntax error #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions meta-oe/classes/image_types_sparse.bbclass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ inherit image_types
SPARSE_BLOCK_SIZE ??= "4096"

CONVERSIONTYPES += "sparse"
CONVERSION_CMD:sparse() {
INPUT="${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
truncate --no-create --size=%${SPARSE_BLOCK_SIZE} "$INPUT"
img2simg -s "$INPUT" "$INPUT.sparse" ${SPARSE_BLOCK_SIZE}
}

CONVERSION_CMD:sparse = " \
truncate --no-create --size=%${SPARSE_BLOCK_SIZE} "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this even work in master (I see this PR is for mickledore, but if you're using this bbclass can you please check in master as well)?

I guess it needs to be updated for changes from:
https://git.openembedded.org/openembedded-core/commit/?id=26d97acc71379ab6702fa54a23b6542a3f51779c

first.

img2simg -s "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}" "${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.sparse" ${SPARSE_BLOCK_SIZE}; \
"

CONVERSION_DEPENDS_sparse = "android-tools-native"