fix(nodejs): package-split between nodejs and nodejs-npm #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nodejs package contains a symbolic link `/usr/bin/corepack` to a file from the nodejs-npm package. ```shell build/tmp/work/core2-64-poky-linux/nodejs/18.14.2-r0/packages-split/nodejs/usr/bin$ ls -l total 31932 lrwxrwxrwx 1 jan jan 45 Feb 21 05:08 corepack -> ../lib/node_modules/corepack/dist/corepack.js -rwxr-xr-x 2 jan jan 32694304 Feb 21 05:08 node build/tmp/work/core2-64-poky-linux/nodejs/18.14.2-r0/packages-split/nodejs-npm/usr/lib/node_modules/corepack/dist$ ls -l total 2428 -rwxr-xr-x 2 jan jan 614216 Feb 21 05:08 corepack.js ``` Due to the link, the build system detects a dependency from package `nodejs` to package `nodejs-npm`. Since the `nodejs-npm` package depends on plenty more packages the link should be moved to the `nodejs-npm` package.
|
applied with 4488418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nodejs package contains a symbolic link
/usr/bin/corepackto a file from the nodejs-npm package.build/tmp/work/core2-64-poky-linux/nodejs/18.14.2-r0/packages-split/nodejs/usr/bin$ ls -l total 31932 lrwxrwxrwx 1 jan jan 45 Feb 21 05:08 corepack -> ../lib/node_modules/corepack/dist/corepack.js -rwxr-xr-x 2 jan jan 32694304 Feb 21 05:08 node build/tmp/work/core2-64-poky-linux/nodejs/18.14.2-r0/packages-split/nodejs-npm/usr/lib/node_modules/corepack/dist$ ls -l total 2428 -rwxr-xr-x 2 jan jan 614216 Feb 21 05:08 corepack.jsDue to the link, the build system detects a dependency from package
nodejsto packagenodejs-npm.Since the
nodejs-npmpackage depends on plenty more packages the linkshould be moved to the
nodejs-npmpackage.