Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googletests: Update SRC_URI to 9e71237 to move closer to latest version #564

Closed
wants to merge 2 commits into from

Conversation

wltu
Copy link
Contributor

@wltu wltu commented Apr 10, 2022

Picked google/googletest@9e71237
as the latest Verified commit and move closer to the HEAD of
googletests. Googletests does not make releases that often and some good
to have features are missing.

Updated the do_config to reflect the new python scripts used in googletests.

Current python scripts are in

$ git grep "/usr/bin/env python"
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_output_test.py:#!/usr/bin/env python
googletest/test/googletest-break-on-failure-unittest.py:#!/usr/bin/env python
googletest/test/googletest-catch-exceptions-test.py:#!/usr/bin/env python
googletest/test/googletest-color-test.py:#!/usr/bin/env python
googletest/test/googletest-env-var-test.py:#!/usr/bin/env python
googletest/test/googletest-failfast-unittest.py:#!/usr/bin/env python
googletest/test/googletest-filter-unittest.py:#!/usr/bin/env python
googletest/test/googletest-json-outfiles-test.py:#!/usr/bin/env python
googletest/test/googletest-json-output-unittest.py:#!/usr/bin/env python
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_output_test.py:#!/usr/bin/env python
googletest/test/googletest-break-on-failure-unittest.py:#!/usr/bin/env python
googletest/test/googletest-catch-exceptions-test.py:#!/usr/bin/env python
googletest/test/googletest-color-test.py:#!/usr/bin/env python
googletest/test/googletest-env-var-test.py:#!/usr/bin/env python
googletest/test/googletest-failfast-unittest.py:#!/usr/bin/env python
googletest/test/googletest-filter-unittest.py:#!/usr/bin/env python
googletest/test/googletest-json-outfiles-test.py:#!/usr/bin/env python
googletest/test/googletest-json-output-unittest.py:#!/usr/bin/env python
googletest/test/googletest-list-tests-unittest.py:#!/usr/bin/env python
googletest/test/googletest-output-test.py:#!/usr/bin/env python
googletest/test/googletest-param-test-invalid-name1-test.py:#!/usr/bin/env python
googletest/test/googletest-param-test-invalid-name2-test.py:#!/usr/bin/env python
googletest/test/googletest-setuptestsuite-test.py:#!/usr/bin/env python
googletest/test/googletest-shuffle-test.py:#!/usr/bin/env python
googletest/test/googletest-throw-on-failure-test.py:#!/usr/bin/env python
googletest/test/googletest-uninitialized-test.py:#!/usr/bin/env python
googletest/test/gtest_help_test.py:#!/usr/bin/env python
googletest/test/gtest_list_output_unittest.py:#!/usr/bin/env python
googletest/test/gtest_skip_check_output_test.py:#!/usr/bin/env python
googletest/test/gtest_skip_environment_check_output_test.py:#!/usr/bin/env python
googletest/test/gtest_testbridge_test.py:#!/usr/bin/env python
googletest/test/gtest_xml_outfiles_test.py:#!/usr/bin/env python
googletest/test/gtest_xml_output_unittest.py:#!/usr/bin/env python

Signed-off-by: Willy Tu [email protected]

Picked google/googletest@9e71237
as the latest Verified commit and move closer to the HEAD of
googletests. Googletests does not make releases that often and some good
to have features are missing.

Signed-off-by: Willy Tu <[email protected]>
@kraj
Copy link
Contributor

kraj commented Apr 10, 2022

@wltu this fails in do_configure see https://errors.yoctoproject.org/Errors/Details/654468/

…lder

Current python script is in
```
$ git grep "/usr/bin/env python"
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_output_test.py:#!/usr/bin/env python
googletest/test/googletest-break-on-failure-unittest.py:#!/usr/bin/env python
googletest/test/googletest-catch-exceptions-test.py:#!/usr/bin/env python
googletest/test/googletest-color-test.py:#!/usr/bin/env python
googletest/test/googletest-env-var-test.py:#!/usr/bin/env python
googletest/test/googletest-failfast-unittest.py:#!/usr/bin/env python
googletest/test/googletest-filter-unittest.py:#!/usr/bin/env python
googletest/test/googletest-json-outfiles-test.py:#!/usr/bin/env python
googletest/test/googletest-json-output-unittest.py:#!/usr/bin/env python
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_leak_test.py:#!/usr/bin/env python
googlemock/test/gmock_output_test.py:#!/usr/bin/env python
googletest/test/googletest-break-on-failure-unittest.py:#!/usr/bin/env python
googletest/test/googletest-catch-exceptions-test.py:#!/usr/bin/env python
googletest/test/googletest-color-test.py:#!/usr/bin/env python
googletest/test/googletest-env-var-test.py:#!/usr/bin/env python
googletest/test/googletest-failfast-unittest.py:#!/usr/bin/env python
googletest/test/googletest-filter-unittest.py:#!/usr/bin/env python
googletest/test/googletest-json-outfiles-test.py:#!/usr/bin/env python
googletest/test/googletest-json-output-unittest.py:#!/usr/bin/env python
googletest/test/googletest-list-tests-unittest.py:#!/usr/bin/env python
googletest/test/googletest-output-test.py:#!/usr/bin/env python
googletest/test/googletest-param-test-invalid-name1-test.py:#!/usr/bin/env python
googletest/test/googletest-param-test-invalid-name2-test.py:#!/usr/bin/env python
googletest/test/googletest-setuptestsuite-test.py:#!/usr/bin/env python
googletest/test/googletest-shuffle-test.py:#!/usr/bin/env python
googletest/test/googletest-throw-on-failure-test.py:#!/usr/bin/env python
googletest/test/googletest-uninitialized-test.py:#!/usr/bin/env python
googletest/test/gtest_help_test.py:#!/usr/bin/env python
googletest/test/gtest_list_output_unittest.py:#!/usr/bin/env python
googletest/test/gtest_skip_check_output_test.py:#!/usr/bin/env python
googletest/test/gtest_skip_environment_check_output_test.py:#!/usr/bin/env python
googletest/test/gtest_testbridge_test.py:#!/usr/bin/env python
googletest/test/gtest_xml_outfiles_test.py:#!/usr/bin/env python
googletest/test/gtest_xml_output_unittest.py:#!/usr/bin/env python
```

Signed-off-by: Willy Tu <[email protected]>
@wltu
Copy link
Contributor Author

wltu commented Apr 11, 2022

@kraj Thanks for the feedback. I have updated it and also built it locally to make sure that I don't miss anything else.

@kraj
Copy link
Contributor

kraj commented Apr 11, 2022

applied with cf80085

@kraj kraj closed this Apr 11, 2022
@wltu
Copy link
Contributor Author

wltu commented Apr 11, 2022

Thanks.

@wltu wltu deleted the gtest branch April 11, 2022 23:33
geissonator pushed a commit to openbmc/openbmc-build-scripts that referenced this pull request Apr 13, 2022
The std::span does not support some gtest MACROS and is fixed in
google/googletest#3195 and
google/googletest@e4717df

Including the fixes to support std::span in gtests.

Match the openembedded gtest version in
openembedded/meta-openembedded#564

Change-Id: Ia0171160ee7a0a36c2fb27eb441e25cdec9ba9f1
Signed-off-by: Willy Tu <[email protected]>
bluca pushed a commit to bluca/meta-openembedded that referenced this pull request May 23, 2022
Changelog:
=====================
HA Lovelace controller: Prevent sending connect message twice (openembedded#559)
Bump black from 21.11b0 to 21.11b1 (openembedded#562)
Catch zeroconf errors (openembedded#564)
Bump black from 21.10b0 to 21.11b0 (openembedded#561)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Trevor Gamblin <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Oct 18, 2022
Changelog:
==========
Type-safe socket.get(sockopt::type) openembedded#523
GCC C++14 fix openembedded#553
Support ZMQ_ONLY_FIRST_SUBSCRIBE openembedded#558
Add pkg-config file and instructions openembedded#564 openembedded#570
Fix missing include openembedded#568
Fix monitor test failures openembedded#576
Improved documentation openembedded#519 openembedded#524

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Oct 18, 2022
Changelog:
==========
Type-safe socket.get(sockopt::type) openembedded#523
GCC C++14 fix openembedded#553
Support ZMQ_ONLY_FIRST_SUBSCRIBE openembedded#558
Add pkg-config file and instructions openembedded#564 openembedded#570
Fix missing include openembedded#568
Fix monitor test failures openembedded#576
Improved documentation openembedded#519 openembedded#524

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants