Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade libcamera #496

Closed
wants to merge 2 commits into from
Closed

Upgrade libcamera #496

wants to merge 2 commits into from

Conversation

maurosanjo
Copy link
Contributor

Upgrades libcamera to latest commit, now libcamera.so is a symlink so
made changes to include all created symlinks.

Signed-off-by: Mauro Anjo [email protected]

@maurosanjo
Upgrade libcamera
bc8504b 
Upgrades libcamera to latest commit, now libcamera.so is a symlink so
made changes to include all created symlinks.

Signed-off-by: Mauro Anjo <[email protected]>
@shr-project shr-project mentioned this pull request Nov 30, 2021
Closed
@kraj
Copy link
Contributor

kraj commented Dec 1, 2021

fails to build on musl/aarch64 see
https://errors.yoctoproject.org/Errors/Details/618303/

kraj
kraj requested changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets fix the musl failure

@kraj
Copy link
Contributor

kraj commented Dec 1, 2021

I have added a fix and also submitted libcamera

https://lists.libcamera.org/pipermail/libcamera-devel/2021-December/027989.html

I have staged it form master-next for meta-multimedia as well.

shr-project added a commit to ros/meta-ros that referenced this pull request Dec 3, 2021
@shr-project
packagegroup-ros-turtlebot3-core: include raspicam-node only with ope…
e074810 
…ngl in DISTRO_FEATURES and blacklist otherwise

* now when we're building for arm with ROS DISTRO and aarch64 with webOS OSE DISTRO
  it fails to build raspicam-node because default DISTRO configuration doesn't have
  'opengl' in DISTRO_FEATURES

* fixes:
  NOTE: Resolving any missing task queue dependencies
  ERROR: Nothing PROVIDES 'userland' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb DEPENDS on or otherwise requires it)
  userland was skipped: Recipe is blacklisted: depends on libegl-mesa from mesa-gl which is not available without opengl in DISTRO_FEATURES
  ERROR: Nothing RPROVIDES 'raspicam-node' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb, /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node'
  NOTE: Runtime target 'raspicam-node' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node']
  ERROR: Nothing RPROVIDES 'packagegroup-ros-turtlebot3-core' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'packagegroup-ros-turtlebot3-core'
  NOTE: Runtime target 'packagegroup-ros-turtlebot3-core' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['packagegroup-ros-turtlebot3-core']
  ERROR: Nothing RPROVIDES 'raspicam-node-dev' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node-dev'
  NOTE: Runtime target 'raspicam-node-dev' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node-dev']

* this mess with userland is hopefully temporary and turtlebot3 will eventually
  use the new implementation introduced in Raspberry Pi OS image based on Debian
  Bullseye https://www.raspberrypi.com/news/bullseye-camera-system/
  there are already some changes for this in meta-raspberrypi:
  agherzan/meta-raspberrypi#963
  and meta-oe:
  openembedded/meta-openembedded#496

Signed-off-by: Martin Jansa <[email protected]>
shr-project added a commit to ros/meta-ros that referenced this pull request Dec 3, 2021
@shr-project
packagegroup-ros-turtlebot3-core: include raspicam-node only with ope…
cb37228 
…ngl in DISTRO_FEATURES and blacklist otherwise

* now when we're building for arm with ROS DISTRO and aarch64 with webOS OSE DISTRO
  it fails to build raspicam-node because default DISTRO configuration doesn't have
  'opengl' in DISTRO_FEATURES

* fixes:
  NOTE: Resolving any missing task queue dependencies
  ERROR: Nothing PROVIDES 'userland' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb DEPENDS on or otherwise requires it)
  userland was skipped: Recipe is blacklisted: depends on libegl-mesa from mesa-gl which is not available without opengl in DISTRO_FEATURES
  ERROR: Nothing RPROVIDES 'raspicam-node' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb, /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node'
  NOTE: Runtime target 'raspicam-node' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node']
  ERROR: Nothing RPROVIDES 'packagegroup-ros-turtlebot3-core' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'packagegroup-ros-turtlebot3-core'
  NOTE: Runtime target 'packagegroup-ros-turtlebot3-core' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['packagegroup-ros-turtlebot3-core']
  ERROR: Nothing RPROVIDES 'raspicam-node-dev' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node-dev'
  NOTE: Runtime target 'raspicam-node-dev' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node-dev']

* this mess with userland is hopefully temporary and turtlebot3 will eventually
  use the new implementation introduced in Raspberry Pi OS image based on Debian
  Bullseye https://www.raspberrypi.com/news/bullseye-camera-system/
  there are already some changes for this in meta-raspberrypi:
  agherzan/meta-raspberrypi#963
  and meta-oe:
  openembedded/meta-openembedded#496

Signed-off-by: Martin Jansa <[email protected]>
shr-project added a commit to ros/meta-ros that referenced this pull request Dec 3, 2021
@shr-project
packagegroup-ros-turtlebot3-core: include raspicam-node only with ope…
a1516fa 
…ngl in DISTRO_FEATURES and blacklist otherwise

* now when we're building for arm with ROS DISTRO and aarch64 with webOS OSE DISTRO
  it fails to build raspicam-node because default DISTRO configuration doesn't have
  'opengl' in DISTRO_FEATURES

* fixes:
  NOTE: Resolving any missing task queue dependencies
  ERROR: Nothing PROVIDES 'userland' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb DEPENDS on or otherwise requires it)
  userland was skipped: Recipe is blacklisted: depends on libegl-mesa from mesa-gl which is not available without opengl in DISTRO_FEATURES
  ERROR: Nothing RPROVIDES 'raspicam-node' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb, /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node'
  NOTE: Runtime target 'raspicam-node' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node']
  ERROR: Nothing RPROVIDES 'packagegroup-ros-turtlebot3-core' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'packagegroup-ros-turtlebot3-core'
  NOTE: Runtime target 'packagegroup-ros-turtlebot3-core' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['packagegroup-ros-turtlebot3-core']
  ERROR: Nothing RPROVIDES 'raspicam-node-dev' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node-dev'
  NOTE: Runtime target 'raspicam-node-dev' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node-dev']

* this mess with userland is hopefully temporary and turtlebot3 will eventually
  use the new implementation introduced in Raspberry Pi OS image based on Debian
  Bullseye https://www.raspberrypi.com/news/bullseye-camera-system/
  there are already some changes for this in meta-raspberrypi:
  agherzan/meta-raspberrypi#963
  and meta-oe:
  openembedded/meta-openembedded#496

Signed-off-by: Martin Jansa <[email protected]>
shr-project added a commit to ros/meta-ros that referenced this pull request Dec 3, 2021
@shr-project
packagegroup-ros-turtlebot3-core: include raspicam-node only with ope…
9ca0cb0 
…ngl in DISTRO_FEATURES and blacklist otherwise

* now when we're building for arm with ROS DISTRO and aarch64 with webOS OSE DISTRO
  it fails to build raspicam-node because default DISTRO configuration doesn't have
  'opengl' in DISTRO_FEATURES

* fixes:
  NOTE: Resolving any missing task queue dependencies
  ERROR: Nothing PROVIDES 'userland' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb DEPENDS on or otherwise requires it)
  userland was skipped: Recipe is blacklisted: depends on libegl-mesa from mesa-gl which is not available without opengl in DISTRO_FEATURES
  ERROR: Nothing RPROVIDES 'raspicam-node' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb, /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node'
  NOTE: Runtime target 'raspicam-node' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node']
  ERROR: Nothing RPROVIDES 'packagegroup-ros-turtlebot3-core' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros-common/recipes-core/packagegroups/packagegroup-ros-turtlebot3-core.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'packagegroup-ros-turtlebot3-core'
  NOTE: Runtime target 'packagegroup-ros-turtlebot3-core' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['packagegroup-ros-turtlebot3-core']
  ERROR: Nothing RPROVIDES 'raspicam-node-dev' (but /jenkins/home/anaconda/ros1-noetic-honister/meta-ros/meta-ros1/recipes-extended/raspicam-node/raspicam-node_git.bb RDEPENDS on or otherwise requires it)
  No eligible RPROVIDERs exist for 'raspicam-node-dev'
  NOTE: Runtime target 'raspicam-node-dev' is unbuildable, removing...
  Missing or unbuildable dependency chain was: ['raspicam-node-dev']

* this mess with userland is hopefully temporary and turtlebot3 will eventually
  use the new implementation introduced in Raspberry Pi OS image based on Debian
  Bullseye https://www.raspberrypi.com/news/bullseye-camera-system/
  there are already some changes for this in meta-raspberrypi:
  agherzan/meta-raspberrypi#963
  and meta-oe:
  openembedded/meta-openembedded#496

Signed-off-by: Martin Jansa <[email protected]>
@maurosanjo
Copy link
Contributor Author

maurosanjo commented Dec 3, 2021 •
edited
Loading

@kraj They merged your PR:

https://git.libcamera.org/libcamera/libcamera.git/commit/?id=83dfe7b2231ecde3a8141c1737570176dfd5c30c

should we go to the latest commit?
https://git.libcamera.org/libcamera/libcamera.git

@kraj
Copy link
Contributor

kraj commented Dec 3, 2021

perhaps a do it as a followup ?

@maurosanjo
libcamera: Update source commit
7b71581 
Upgrade libcamera to commit with aarch64 corrections.

Signed-off-by: Mauro Anjo <[email protected]>
@kraj
Copy link
Contributor

kraj commented Dec 6, 2021

this change is not enough I think, you have to drop upstream merged musl patch. I am closing this pull and please do the changes on latest master and open a new pull.

@kraj kraj closed this Dec 6, 2021
@maurosanjo maurosanjo deleted the update_libcamera branch December 6, 2021 19:30
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Jan 7, 2022
@wangmingyu84 @kraj
bats: upgrade 1.4.1 -> 1.5.0
f16f628 
0001-install.sh-consider-multilib.patch
removed since it is included in 1.5.0

Changelog:
Issues for this release <https://github.com/bats-core/bats-core/pull/####>
=========
Added:
---------
 new command line flags (openembedded#488)
 --verbose-run: Make run print $output by default
 -x, --trace: Print test commands as they are executed (like set -x)`
 --show-output-of-passing-tests: Print output of passing tests
 --print-output-on-failure: Automatically print the value of $output on
 failed tests
 --gather-test-outputs-in <directory>: Gather the output of failing and
 passing tests as files in directory
 Experimental: add return code checks to run via !/-<N> (openembedded#367, openembedded#507)
 install.sh and uninstall.sh take an optional second parameter for the lib
 folder name to allow for multilib install, e.g. into lib64 (openembedded#452)
 add run flag --keep-empty-lines to retain empty lines in ${lines[@]} (openembedded#224,
 a894fbf)
 add run flag --separate-stderr which also fills $stderr and
 $stderr_lines (openembedded#47, 5c9b173d, openembedded#507)

Fixed:
---------
 don't glob run's $output when splitting into ${lines[@]}
 (openembedded#151, openembedded#152, openembedded#158, openembedded#156, openembedded#281, openembedded#289)
 remove empty line after test with pretty formatter on some terminals (openembedded#481)
 don't run setup_file/teardown_file on files without tests, e.g. due to
 filtering (openembedded#484)
 print final line without newline on Bash 3.2 for midtest (ERREXIT) failures
 too (openembedded#495, openembedded#145)
 abort with error on missing flock/shlock when running in parallel mode (openembedded#496)
 improved set -u test and fixed some unset variable accesses (openembedded#498, openembedded#501)
 shorten suite/file/test temporary folder paths to leave enough space even on
 restricted systems (openembedded#503)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/meta-openembedded that referenced this pull request Mar 23, 2023
@VKumbhar24 @jpuhlman
c-ares:fix CVE-2022-4904 buffer overflow in config_sortlist() due to …
0699307 
…missing string length check

Source: c-ares/c-ares@9903253
MR: 125266
Type: Security Fix
Disposition: Backport from c-ares/c-ares@9903253
ChangeID: 33b40926ed3ed7620434f30ff30874e241a3257c
Description:

Add str len check in config_sortlist to avoid stack overflow (openembedded#497)
In ares_set_sortlist, it calls config_sortlist(..., sortstr) to parse
the input str and initialize a sortlist configuration.

However, ares_set_sortlist has not any checks about the validity of the input str.
It is very easy to create an arbitrary length stack overflow with the unchecked
`memcpy(ipbuf, str, q-str);` and `memcpy(ipbufpfx, str, q-str);`
statements in the config_sortlist call, which could potentially cause severe
security impact in practical programs.

This commit add necessary check for `ipbuf` and `ipbufpfx` which avoid the
potential stack overflows.

fixes openembedded#496

Fix By: @hopper-vul

Upstream-Status: Backport [c-ares/c-ares@9903253]
CVE: CVE-2022-4904
Signed-off-by: Vivek Kumbhar <[email protected]>
Signed-off-by: Jeremy A. Puhlman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraj kraj kraj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurosanjo @kraj