Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta-oe] devtools/php: remove the failing ${D}/${TMPDIR} code #292

Closed
wants to merge 1 commit into from
Closed

[meta-oe] devtools/php: remove the failing ${D}/${TMPDIR} code #292

wants to merge 1 commit into from

Conversation

MaxKellermann
Copy link
Contributor

Appending ${TMPDIR} to ${D} doesn't make any sense, because both are
absolute paths. And additionally, the code fails:

rmdir: failed to remove '/usr/src/oe/tmp-musl/work/core2-64-oe-linux-musl/php/7.1.9-r0/image//usr': Directory not empty

Signed-off-by: Max Kellermann [email protected]

(This is the successor of #66 which I cannot update because I had deleted my fork long ago. @kraj)

@MaxKellermann
[meta-oe] devtools/php: remove the failing ${D}/${TMPDIR} code
96b61f8 
Appending ${TMPDIR} to ${D} doesn't make any sense, because both are
absolute paths.  And additionally, the code fails:

 rmdir: failed to remove '/usr/src/oe/tmp-musl/work/core2-64-oe-linux-musl/php/7.1.9-r0/image//usr': Directory not empty

Signed-off-by: Max Kellermann <[email protected]>
@MaxKellermann MaxKellermann mentioned this pull request Nov 20, 2020
Closed
@shr-project
Copy link
Contributor

I guess you're seeing this issue because our TMPDIR starts with /usr while for most people it will be something line /home/foo or /OE etc which don't conflict with valid files in ${D}/usr

But it made sense in 2013 when it was introduced https://git.openembedded.org/meta-openembedded/commit/?id=357915b6d11dfa612fbadaa4966a0b3e0f332467 and if php still does install files in this wrong location, then it still needs to be fixed not just reverted.

@MaxKellermann
Copy link
Contributor Author

If PHP installs files in those insane locations, then this bug should be patched in the PHP build system, instead of trying to fix it up after the fact.

@shr-project
Copy link
Contributor

If PHP installs files in those insane locations, then this bug should be patched in the PHP build system, instead of trying to fix it up after the fact.

agreed, it was just work around in 2013 and nobody sent patch to properly fix that since then

@kraj
Copy link
Contributor

kraj commented Nov 24, 2020

@MaxKellermann thanks, has this been tested in non /usr tmpdir env?

@kraj
Copy link
Contributor

kraj commented Dec 1, 2020

this has been merged via 5cd29d5

@kraj kraj closed this Dec 1, 2020
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Jun 5, 2023
@wangmingyu84 @kraj
python3-cachecontrol: upgrade 0.12.12 -> 0.13.0
de8ba92 
Changelog:
==========
    Fix openembedded#292: disuse HTTPResponse.strict
    fix: double reading error on urllib3 2.0
    Packaging the tests, or not
    Add type annotations
    Use Python's unittest mock
    feat: remove compat module
    tests: Support python 3.11
    fix: use pytest native method name
    Remove use of utcnow
    Release 0.13.0

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 19, 2024
@quaresmajose @kraj
composefs: upgrade 1.0.4 -> 1.0.5
0d28cf5 
- switch to meson build system

Changelog [1]:

$ git --no-pager log --oneline v1.0.4..v1.0.5
098d985 (tag: v1.0.5) Merge pull request openembedded#312 from cgwalters/release
0fae8a8 Release 1.0.5
9bdc377 Merge pull request openembedded#310 from cgwalters/symlink-limit
b06ea9b Verify payload length early on
3beb011 Merge pull request openembedded#308 from cgwalters/minor-rust-lints
a695ad4 Merge pull request openembedded#309 from giuseppe/libcomposefs-drop-ro
0a0d50f libcomposefs: drop using "ro" option
b35dc83 dumpfile: Fix clippy lint
a919ab8 rust: Drop unused cfg
3a87868 Merge pull request openembedded#307 from giuseppe/not-override-errno
bb94687 Merge pull request openembedded#306 from giuseppe/mkcomposefs-report-close-errors
76b4da5 mkcompose: report close() errors
502bc27 libcomposefs: do not override errno
2d2c09d Merge pull request openembedded#304 from jluebbe/meson
0260856 meson.build: Allow use as a meson subproject
5f512ac Merge pull request openembedded#303 from cgwalters/mount-source
91a3047 mount: Consistently use `composefs` as source
45e6179 Merge pull request openembedded#302 from cgwalters/info-term
f64022f info: Add missing terminator for `longopts`
d81cb87 Merge pull request openembedded#300 from jluebbe/meson
04c8a8e ci: Add GitHub Actions workflow which uses meson
64709f6 ci: Install meson package
b6f2b75 Add meson as an alternative to autotools
942cd73 Merge pull request openembedded#299 from giuseppe/composefs-info-set-locale
5072fd7 composefs-info: specify locale to isgraph/isprint
4f19d00 Merge pull request openembedded#298 from cgwalters/rust-misc
43a1d28 rust: Add README.md files, link to crates.io
a8bc747 rust: Clarify that "composefs-core" is really "composefs"
483356c Merge pull request openembedded#297 from cgwalters/rust-include
02213c0 composefs-core: Drop incorrect `include`
dce84ff Merge pull request openembedded#295 from cgwalters/rust-descr
3d2af03 Merge pull request openembedded#296 from Kiskae/upstream-tmpdir-fix
6928fcf test: remove hardcoded /tmp
e21be07 rust: Add mandatory `description` field, other misc changes
28dc491 Merge pull request openembedded#292 from cgwalters/rust-ci-dual
59c5a27 Merge pull request openembedded#293 from cgwalters/rust-minor
689ccc6 rust: Some doc and misc tweaks
426b65d ci: Test Rust code against current C code
32b3f6e Merge pull request openembedded#291 from Kiskae/patch-1
f7465b3 use correct `composefs-info` binary

[1] containers/composefs@v1.0.4...v1.0.5

Signed-off-by: Jose Quaresma <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 19, 2024
@quaresmajose @kraj
composefs: upgrade 1.0.4 -> 1.0.5
bb62f52 
- switch to meson build system

Changelog [1]:

$ git --no-pager log --oneline v1.0.4..v1.0.5
098d985 (tag: v1.0.5) Merge pull request openembedded#312 from cgwalters/release
0fae8a8 Release 1.0.5
9bdc377 Merge pull request openembedded#310 from cgwalters/symlink-limit
b06ea9b Verify payload length early on
3beb011 Merge pull request openembedded#308 from cgwalters/minor-rust-lints
a695ad4 Merge pull request openembedded#309 from giuseppe/libcomposefs-drop-ro
0a0d50f libcomposefs: drop using "ro" option
b35dc83 dumpfile: Fix clippy lint
a919ab8 rust: Drop unused cfg
3a87868 Merge pull request openembedded#307 from giuseppe/not-override-errno
bb94687 Merge pull request openembedded#306 from giuseppe/mkcomposefs-report-close-errors
76b4da5 mkcompose: report close() errors
502bc27 libcomposefs: do not override errno
2d2c09d Merge pull request openembedded#304 from jluebbe/meson
0260856 meson.build: Allow use as a meson subproject
5f512ac Merge pull request openembedded#303 from cgwalters/mount-source
91a3047 mount: Consistently use `composefs` as source
45e6179 Merge pull request openembedded#302 from cgwalters/info-term
f64022f info: Add missing terminator for `longopts`
d81cb87 Merge pull request openembedded#300 from jluebbe/meson
04c8a8e ci: Add GitHub Actions workflow which uses meson
64709f6 ci: Install meson package
b6f2b75 Add meson as an alternative to autotools
942cd73 Merge pull request openembedded#299 from giuseppe/composefs-info-set-locale
5072fd7 composefs-info: specify locale to isgraph/isprint
4f19d00 Merge pull request openembedded#298 from cgwalters/rust-misc
43a1d28 rust: Add README.md files, link to crates.io
a8bc747 rust: Clarify that "composefs-core" is really "composefs"
483356c Merge pull request openembedded#297 from cgwalters/rust-include
02213c0 composefs-core: Drop incorrect `include`
dce84ff Merge pull request openembedded#295 from cgwalters/rust-descr
3d2af03 Merge pull request openembedded#296 from Kiskae/upstream-tmpdir-fix
6928fcf test: remove hardcoded /tmp
e21be07 rust: Add mandatory `description` field, other misc changes
28dc491 Merge pull request openembedded#292 from cgwalters/rust-ci-dual
59c5a27 Merge pull request openembedded#293 from cgwalters/rust-minor
689ccc6 rust: Some doc and misc tweaks
426b65d ci: Test Rust code against current C code
32b3f6e Merge pull request openembedded#291 from Kiskae/patch-1
f7465b3 use correct `composefs-info` binary

[1] containers/composefs@v1.0.4...v1.0.5

Signed-off-by: Jose Quaresma <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxKellermann @shr-project @kraj