Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#857 store intermediate results of heat demand timeseries #870

Conversation

ClaraBuettner
Copy link
Contributor

@ClaraBuettner ClaraBuettner commented Aug 18, 2022

Fixes #857 .
Fixes #950

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@nailend
Copy link
Contributor

nailend commented Sep 17, 2022

This column does not exist as described in the database as the table is exported with different columns here. Please adapt the class definition accordingly. Just to mention: If you use pd.to_sql with if_exists=replace pandas will choose the datatype of the columns by itself and not stick to your definition. Thats why they end up without PK defined. You might also have to define the dtypes explicitly.

You can use this to not hardcode all of them :

dtypes = {column.key: column.type for column in EgonDailyHeatDemandPerClimateZone.__table__.columns}

@ClaraBuettner ClaraBuettner marked this pull request as ready for review September 30, 2022 07:00
@ClaraBuettner
Copy link
Contributor Author

Most of the commits from this feature branch were already merged into dev (see #950), theses are not visible in this PR anymore. I don't really know how to deal with this, there were several commits and it is not really possible to find all of them again.

@ClaraBuettner ClaraBuettner merged commit d33f862 into dev Sep 30, 2022
@nesnoj nesnoj deleted the features/#857-store-intermediate-results-of-heat-demand-timeseries branch October 24, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merged content of draft-PR to dev Store intermediate results of heat demand timeseries
3 participants