Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed CHANGELOG error. #32

Merged

Conversation

saleem-latif
Copy link
Contributor

Description:
Fixed and error inside the CHANGELOG entry that was causing the a failure while uploading to PyPI.

JIRA : ENT-8458

Testing instructions:

  1. PyPI upload should work successfully after creating a release tag.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@saleem-latif saleem-latif self-assigned this Mar 18, 2024
@irfanuddinahmad irfanuddinahmad merged commit c7d3723 into openedx:main Mar 18, 2024
5 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/fix-pypi-upload branch March 18, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants