fix: ensure that LTI 1.3 launches work #527
Merged
+31
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
commented
Jan 15, 2025
| @@ -86,13 +86,6 @@ def _get_keyset(self, kid=None): | |||
| raise exceptions.NoSuitableKeys() from err | |||
| keyset.extend(keys.keys) | |||
|
|
|||
| if self.public_key and kid: | |||
There was a problem hiding this comment.
I removed this as the _get_keyset function was never being called with a non-none kid value. The comment also suggests this was related to pyjwkest verification, but verification is passing using pyjwt
alangsto
force-pushed
the
alangsto/fix_lti_1p3
branch
from
170d375 to
bcdb683
Compare
MichaelRoytman
approved these changes
Jan 15, 2025
CHANGELOG.rst
Outdated
| @@ -16,6 +16,10 @@ Please See the `releases tab <https://github.com/openedx/xblock-lti-consumer/rel | |||
| Unreleased | |||
| ~~~~~~~~~~ | |||
|
|
|||
| 9.13.1 - 2025-01-15 | |||
| ------------------- | |||
| * Fix broken LTI 1.3 launch | |||
There was a problem hiding this comment.
Could you make this a little more descriptive, so that it's clear what the bug was/what was fixed, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-629
Changes introduced in v9.13.0 caused LTI 1.3 launches to not function. This was because the
kidfield was missing from both the JWT header sent to the tool, and from the public keyset endpoint.This PR adds the
kidto the JWT header and ensures that thekidis also available in the public keyset endpoint. I've also removed somepyjwkestrelated code that is no longer needed.