-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
9 changed files
with
152 additions
and
1 deletion.
There are no files selected for viewing
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
from rest_framework import serializers | ||
from taxonomy.models import Skill | ||
|
||
|
||
class SkillSerializer(serializers.ModelSerializer): | ||
""" Skill Searlizer """ | ||
|
||
class Meta: | ||
model = Skill | ||
fields = ('name', 'description') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
from django.urls import path | ||
from taxonomy.api.v1.views import SkillsView | ||
|
||
urlpatterns = [ | ||
path('api/v1/skills/', SkillsView.as_view(), name='skill_list') | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
from rest_framework.generics import ListAPIView | ||
from rest_framework.permissions import IsAuthenticated | ||
from rest_framework import filters | ||
from taxonomy.models import Skill, CourseSkills | ||
from taxonomy.api.v1.serializers import SkillSerializer | ||
|
||
|
||
class SkillsView(ListAPIView): | ||
""" List view for Skills """ | ||
filter_backends = [filters.SearchFilter] | ||
search_fields = ['^name'] | ||
permission_classes = [IsAuthenticated] | ||
serializer_class = SkillSerializer | ||
|
||
def get_queryset(self): | ||
blacklisted_skill_ids = list( | ||
CourseSkills.objects.filter(is_blacklisted=True).values_list('skill__id', flat=True) | ||
) | ||
return Skill.objects.exclude(id__in=blacklisted_skill_ids) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
from pytest import mark | ||
from django.urls import reverse | ||
|
||
from rest_framework.test import APITestCase | ||
from rest_framework import status | ||
from test_utils import factories | ||
|
||
|
||
TEST_USERNAME = 'taxonomy_user' | ||
TEST_EMAIL = '[email protected]' | ||
TEST_PASSWORD = 'password' | ||
|
||
|
||
@mark.django_db | ||
class TestSkillsView(APITestCase): | ||
def setUp(self): | ||
""" | ||
Perform operations common to all tests. | ||
""" | ||
super().setUp() | ||
self.user = self.create_user(username=TEST_USERNAME, email=TEST_EMAIL, password=TEST_PASSWORD) | ||
|
||
self.url = reverse('skill_list') | ||
|
||
self.whitelisted_skills = [ | ||
'C Plus Plus', 'Command Line Interface', 'Data Strcutures', 'Biochemistry', 'Animations', 'Algorithms' | ||
] | ||
self.blacklisted_skills = ['Visual Basic', 'Oracle'] | ||
|
||
for skill_name in self.whitelisted_skills: | ||
skill = factories.SkillFactory(name=skill_name) | ||
factories.CourseSkillsFactory(skill=skill) | ||
|
||
for skill_name in self.blacklisted_skills: | ||
skill = factories.SkillFactory(name=skill_name) | ||
factories.CourseSkillsFactory(skill=skill, is_blacklisted=True) | ||
|
||
self.client.login(username=TEST_USERNAME, password=TEST_PASSWORD) | ||
|
||
def create_user(self, username=TEST_USERNAME, password=TEST_PASSWORD, **kwargs): | ||
""" | ||
Create a test user and set its password. | ||
""" | ||
user = factories.UserFactory(username=username, **kwargs) | ||
user.set_password(password) # pylint: disable=no-member | ||
user.save() # pylint: disable=no-member | ||
return user | ||
|
||
def test_search(self): | ||
""" | ||
Verify that skills endppoint return all skills when `search` query param is not given | ||
""" | ||
response = self.client.get(path=self.url) | ||
assert response.status_code == status.HTTP_200_OK | ||
skill_names = [skill['name'] for skill in response.json()] | ||
assert sorted(skill_names) == sorted(self.whitelisted_skills) | ||
|
||
def test_search_with_query_param(self): | ||
""" | ||
Verify that skills endppoint return filtered skills according to the `search` query param | ||
""" | ||
response = self.client.get(path=self.url + '?search=algo') | ||
assert response.status_code == status.HTTP_200_OK | ||
skill_names = [skill['name'] for skill in response.json()] | ||
assert skill_names == ['Algorithms'] | ||
|
||
def test_search_with_blacklisted_skill(self): | ||
""" | ||
Verify that skills endppoint does not return blacklised skills. | ||
""" | ||
response = self.client.get(path=self.url + '?search=Oracle') | ||
assert response.status_code == status.HTTP_200_OK | ||
skill_names = [skill['name'] for skill in response.json()] | ||
assert skill_names == [] |