Automate Browserlist DB Update #1664
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 90.73% // Head: 90.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
+ Coverage 90.73% 90.86% +0.12%
==========================================
Files 233 212 -21
Lines 4082 3764 -318
Branches 966 899 -67
==========================================
- Hits 3704 3420 -284
+ Misses 371 342 -29
+ Partials 7 2 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -0,0 +1,41 @@ | |||
| name: Update Browserlist DB | |||
There was a problem hiding this comment.
Is this Github Action workflow essentially the same for all repos that use browserslist? If so, should we define the workflow once in a shared place that can be used by many repos?
Like what we do with the shared commit linting Github Action workflow file across all the repos: https://github.com/openedx/paragon/blob/master/.github/workflows/lockfileversion-check.yml#L11-L13
The shared Github Action workflows are defined here: https://github.com/openedx/.github/tree/master/workflow-templates, and should be accessible across repos without having to duplicate workflow files, resulting in more maintainable code.
Also, nit: let's change "browserlist" -> "browserslist" to match the actual name of browserslist.
There was a problem hiding this comment.
yeah it seems a right way to do this, let me create a PR there
There was a problem hiding this comment.
created this PR for shared workflow
There was a problem hiding this comment.
@abdullahwaheed Left some comments on the PR for the shared workflow!
There was a problem hiding this comment.
yes, updating that PR on the basis of your review
| schedule: | ||
| - cron: '0 0 * * 1' | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Great to provide a manual way to trigger the workflow! 🙌
…ed/auto-update-browserlist
|
@adamstankiewicz its ready for review |
|
Thanks @abdullahwaheed! :) I'll go ahead and merge this when the CI passes. |
|
🎉 This PR is included in version 20.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 21.0.0-alpha.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ticket
Automate browserslist DB update
What has changed
Added a Github workflow that would run periodically(weekly), update browserslist DB, create a PR and merge it automatically.
Used a shared workflow for this