feat: Added support for node v16 #1068

+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}
+      run: npx semantic-release --dry-run --branches=${{ steps.extract_branch.outputs.branch
+        }}


nit: unnecessary newline? I believe }} could be on previous line?

adamstankiewicz · 2022-02-03T19:24:45Z

package.json

@@ -44,7 +44,7 @@
    "font-awesome": "^4.7.0",
    "lodash.uniqby": "^4.7.0",
    "mailto-link": "^1.0.0",
-    "prop-types": "^15.8.1",
+    "prop-types": "^15.7.2",


Curious why this was downgraded?

Jawayria · 2022-02-25T17:29:20Z

@Jawayria you can update the snapshots and update the PR as per @adamstankiewicz we are okay to update those failed snapshots in the tests

you can run fedx-scripts jest --updateSnapshot or sth like it to update the jest snapshots and submit the changes

Updated the snapshots. Now tests are passing with Node 12 and 14 but one test failure with Node 16

binodpant · 2022-02-28T15:34:58Z

hmm I saw this same error in the explore catalog node16 node

I looked last week and have not figured out why yet... it seems there is an error about MutationObserver, which probably has changed api and some lib is still using it?

node:internal/process/promises:265
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "TypeError: MutationObserver is not a constructor".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

binodpant · 2022-02-28T15:36:10Z

maybe this is useful: testing-library/dom-testing-library#477

binodpant · 2022-02-28T15:41:37Z

actually for me it was due to a different reason but the same path of failures

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Error: Warning: An update to %s inside a test was not wrapped in act(...).

When testing, code that causes React state updates should be wrapped into act(...):

Jawayria · 2022-03-01T08:42:23Z

package.json

-    "jest": "^24.5.0",
-    "jest-cli": "^24.7.1",
+    "jest": "^25.0.0",
+    "jest-cli": "^25.0.0",


Updated jest version to fix TypeError: MutationObserver is not a constructor" when running tests with Node 16.
Reference

Jawayria · 2022-03-01T08:50:26Z

src/Button/deprecated/Button.test.jsx

    wrapper = mount(<Button
      {...defaultProps}
-    />);
+    />, { attachTo: app });


Jest v25 uses jsdom v15 (link) and all the tests related to focus started to fail due to the changes introduced in jsdom v15 (link). So I have updated the tests and introduced attachTo in order to fix this issue following these references: 1 2

added this to troubleshooting section of doc https://openedx.atlassian.net/wiki/spaces/AC/pages/3318054984/Node+16+Upgrade

adamstankiewicz

LGTM once we resolve the eslint issues by bringing the changes from here into this PR first.

When we merge this, I think we'll want the semantic-release type to be feat instead of build to denote via a new release version that Node 16 is now officially supported and so the changes to prop types are published as well.

codecov · 2022-03-02T08:40:27Z

Codecov Report

Merging #1068 (3d3d8a2) into master (5f9e3db) will decrease coverage by 0.27%.
The diff coverage is 33.33%.

❗ Current head 3d3d8a2 differs from pull request most recent head fdfdf5b. Consider uploading reports for the commit fdfdf5b to get more accurate results

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
- Coverage   90.86%   90.59%   -0.28%     
==========================================
  Files         180      190      +10     
  Lines        2738     2989     +251     
  Branches      560      657      +97     
==========================================
+ Hits         2488     2708     +220     
- Misses        237      268      +31     
  Partials       13       13

Impacted Files	Coverage Δ
src/DataTable/CollapsibleButtonGroup.jsx	`100.00% <ø> (ø)`
src/DataTable/filters/CheckboxFilter.jsx	`100.00% <ø> (ø)`
...rc/DataTable/filters/MultiSelectDropdownFilter.jsx	`100.00% <ø> (ø)`
src/Icon/index.jsx	`100.00% <ø> (ø)`
src/InputSelect/index.jsx	`12.50% <ø> (-0.55%)`	⬇️
src/Modal/ModalDialogHeroBackground.jsx	`100.00% <ø> (ø)`
src/Modal/PopperElement.jsx	`100.00% <ø> (ø)`
src/Modal/index.jsx	`92.50% <ø> (ø)`
src/Overlay/index.jsx	`100.00% <ø> (ø)`
src/Popover/index.jsx	`100.00% <ø> (ø)`
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9e3db...fdfdf5b. Read the comment docs.

feat: Added support for Node 16

edx-semantic-release · 2022-03-02T14:32:36Z

🎉 This PR is included in version 19.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

binodpant requested a review from adamstankiewicz February 24, 2022 14:18

binodpant mentioned this pull request Feb 24, 2022

Paragon change to add node test matrix openedx/wg-frontend#80

Closed

adamstankiewicz reviewed Feb 25, 2022

View reviewed changes

Jawayria commented Mar 1, 2022

View reviewed changes

adamstankiewicz approved these changes Mar 1, 2022

View reviewed changes

adamstankiewicz mentioned this pull request Mar 1, 2022

build: use shared browserslist config #868

Closed

Jawayria changed the title ~~build: Added support for node v16~~ feat: Added support for node v16 Mar 2, 2022

mraarif approved these changes Mar 2, 2022

View reviewed changes

feat: Added support for node v16

fdfdf5b

feat: Added support for Node 16

Jawayria force-pushed the jawayria/node-16 branch from 3d3d8a2 to fdfdf5b Compare March 2, 2022 14:11

Jawayria merged commit a813309 into master Mar 2, 2022

Jawayria deleted the jawayria/node-16 branch March 2, 2022 14:25

edx-semantic-release added the released label Mar 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added support for node v16 #1068

feat: Added support for node v16 #1068

Jawayria commented Feb 3, 2022 •

edited

Loading

netlify bot commented Feb 3, 2022 •

edited

Loading

netlify bot commented Feb 3, 2022 •

edited

Loading

binodpant commented Feb 24, 2022

adamstankiewicz left a comment

adamstankiewicz Feb 3, 2022

adamstankiewicz Feb 3, 2022

Jawayria commented Feb 25, 2022

binodpant commented Feb 28, 2022

binodpant commented Feb 28, 2022

binodpant commented Feb 28, 2022

Jawayria Mar 1, 2022

Jawayria Mar 1, 2022

binodpant Mar 2, 2022

adamstankiewicz left a comment

codecov bot commented Mar 2, 2022 •

edited

Loading

edx-semantic-release commented Mar 2, 2022

feat: Added support for node v16 #1068

feat: Added support for node v16 #1068

Conversation

Jawayria commented Feb 3, 2022 • edited Loading

netlify bot commented Feb 3, 2022 • edited Loading

netlify bot commented Feb 3, 2022 • edited Loading

binodpant commented Feb 24, 2022

adamstankiewicz left a comment

Choose a reason for hiding this comment

adamstankiewicz Feb 3, 2022

Choose a reason for hiding this comment

adamstankiewicz Feb 3, 2022

Choose a reason for hiding this comment

Jawayria commented Feb 25, 2022

binodpant commented Feb 28, 2022

binodpant commented Feb 28, 2022

binodpant commented Feb 28, 2022

Jawayria Mar 1, 2022

Choose a reason for hiding this comment

Jawayria Mar 1, 2022

Choose a reason for hiding this comment

binodpant Mar 2, 2022

Choose a reason for hiding this comment

adamstankiewicz left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 2, 2022 • edited Loading

Codecov Report

edx-semantic-release commented Mar 2, 2022

Jawayria commented Feb 3, 2022 •

edited

Loading

netlify bot commented Feb 3, 2022 •

edited

Loading

netlify bot commented Feb 3, 2022 •

edited

Loading

codecov bot commented Mar 2, 2022 •

edited

Loading