Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat! Turn off survey link for merged/closed PRs #299

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Aug 23, 2024

Per discussion in standup, let's disable this for now until we have a better story around looking at the data and only posting on first-timers PRs

@sarina
Copy link
Contributor Author

sarina commented Aug 23, 2024

@kdmccormick is this right?

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🙌🏻 🦘

@kdmccormick kdmccormick enabled auto-merge (squash) August 27, 2024 18:56
@kdmccormick kdmccormick disabled auto-merge August 27, 2024 18:56
@kdmccormick kdmccormick merged commit 7f7e8da into master Aug 27, 2024
2 of 4 checks passed
@kdmccormick kdmccormick deleted the turn-off-survey branch August 27, 2024 18:57
@kdmccormick
Copy link
Member

@sarina I merged your PR, the only issue was commitlint wanted feat! to be feat!:.

I'm not sure if this will autodeploy or if there's some step you need to do in order to deploy it.

@sarina
Copy link
Contributor Author

sarina commented Aug 27, 2024

Oh thanks, I was thinking I had to make the other tests pass and hadn't looked into those yet.

If it doesn't autodeploy I suppose we ask Feanil when he returns

@kdmccormick
Copy link
Member

@sarina whoops, I totally missed that there were unit test failures in alongside the commitlint failure 😅 Could you give #301 a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants