Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov, replace with python-coverage-comment-action #300

Closed
wants to merge 3 commits into from
Closed

Remove codecov, replace with python-coverage-comment-action #300

wants to merge 3 commits into from

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Jan 9, 2024

Description: Describe in a couple of sentences what this PR adds

ISSUE: Link to GitHub issue

Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

  • tag reviewer
  • tag reviewer

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@nedbat
Copy link
Contributor Author

nedbat commented Jan 19, 2024

@dianakhuang @timmc-edx @robrap Feel free to do something with this if you like.

@nedbat nedbat closed this Jan 19, 2024
@robrap
Copy link
Contributor

robrap commented Jan 19, 2024

Thanks @nedbat. Let us know if there is any other status you could report, other than just looking at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants