Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Mark OEP-42 as Deferred #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: Mark OEP-42 as Deferred #612

wants to merge 1 commit into from

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Jul 9, 2024

Mark OEP as Deferred, as per #489

@sarina
docs: Mark OEP-42 as Deferred
236dd38 
Mark OEP as Deferred, as per #489
@sarina sarina mentioned this pull request Jul 9, 2024
Open
@sarina
Copy link
Contributor Author

sarina commented Jul 18, 2024

@robrap are you good with this change?

robrap
robrap reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had missed this. This doesn’t really make sense to me because this OEP is meant to document our best practices, and I think it does.

The only thing we have deferred is documenting and working on a specific small piece of authentication that isn’t yet addressed in this OEP. If you wish to address it, it could be with a small new section that summarizes the xblock authentication status, rather than updating the status of this entire OEP.

@sarina
Copy link
Contributor Author

sarina commented Jul 18, 2024

@robrap - can you re-read the discussion in this ticket? #489 - I said I was going to take this action, so I guess I'm left a bit confused - what did I miss?

@robrap
Copy link
Contributor

robrap commented Jul 18, 2024

@robrap - can you re-read the discussion in this ticket? #489 - I said I was going to take this action, so I guess I'm left a bit confused - what did I miss?

On that ticket, my last comment was #489 (comment), which feels the same as the comment I left on this PR here #612 (review), neither of which mention marking the entire OEP as deferred. Does this clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap left review comments

@feanil feanil feanil approved these changes

Assignees

@robrap robrap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarina @robrap @feanil