Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded to node v18, added .nvmrc and updated workflows #89

Merged
merged 9 commits into from
May 23, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Mar 15, 2023

Ticket

Upgrade Node Js from 16 to 18

Description

  • Added support for node v18, updated .nvmrc and workflows.
  • Updated frontend-platform & frontend-build versions
  • Resolved respective eslint issues

@BilalQamar95 BilalQamar95 self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6b2ba05) 93.81% compared to head (b753991) 93.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          71       71           
  Lines        1018     1019    +1     
  Branches      280      280           
=======================================
+ Hits          955      956    +1     
  Misses         58       58           
  Partials        5        5           
Impacted Files Coverage Δ
src/exam/Exam.jsx 97.14% <ø> (ø)
...red_exam/ReadyToStartProctoredExamInstructions.jsx 100.00% <ø> (ø)
src/timer/ExamTimerBlock.jsx 100.00% <ø> (ø)
src/timer/TimerProvider.jsx 82.75% <ø> (ø)
src/core/ExamStateProvider.jsx 100.00% <100.00%> (ø)
src/core/OuterExamTimer.jsx 93.75% <100.00%> (ø)
src/data/thunks.js 92.72% <100.00%> (ø)
src/exam/ExamAPIError.jsx 100.00% <100.00%> (ø)
src/exam/ExamWrapper.jsx 100.00% <100.00%> (ø)
...download-instructions/RestProviderInstructions.jsx 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 4, 2023 08:13
@Mashal-m Mashal-m marked this pull request as draft April 20, 2023 11:47
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BilalQamar95 .

One minor change, since there's a more up to date version.

package.json Outdated
@@ -43,6 +43,8 @@
"url": "https://github.com/edx/frontend-lib-special-exams/issues"
},
"dependencies": {
"@edx/frontend-build": "12.7.0",
"@edx/frontend-platform": "4.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@edx/frontend-platform": "4.0.1",
"@edx/frontend-platform": "4.2.0",

Looks like the latest version of platform is now 4.2.0, just a note to make sure to bump to whatever the latest is when merge conflicts are resolved. https://github.com/openedx/frontend-platform/releases

package.json Outdated
@@ -43,6 +43,8 @@
"url": "https://github.com/edx/frontend-lib-special-exams/issues"
},
"dependencies": {
"@edx/frontend-build": "12.7.0",
"@edx/frontend-platform": "4.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@edx/frontend-platform": "4.0.1",
"@edx/frontend-platform": "4.2.0",

Looks like the latest version of platform is now 4.2.0, just a note to make sure to bump to whatever the latest is when merge conflicts are resolved. https://github.com/openedx/frontend-platform/releases

@BilalQamar95 BilalQamar95 reopened this Apr 26, 2023
@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 26, 2023 09:23
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, approved!

@arbrandes arbrandes merged commit e53cb1c into main May 23, 2023
@arbrandes arbrandes deleted the bilalqamar95/node-v18-upgrade branch May 23, 2023 14:03
@github-actions
Copy link

🎉 This PR is included in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants