-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgraded to node v18, added .nvmrc and updated workflows #89
Conversation
…l-exams into bilalqamar95/node-v18-upgrade
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 71 71
Lines 1018 1019 +1
Branches 280 280
=======================================
+ Hits 955 956 +1
Misses 58 58
Partials 5 5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BilalQamar95 .
One minor change, since there's a more up to date version.
package.json
Outdated
@@ -43,6 +43,8 @@ | |||
"url": "https://github.com/edx/frontend-lib-special-exams/issues" | |||
}, | |||
"dependencies": { | |||
"@edx/frontend-build": "12.7.0", | |||
"@edx/frontend-platform": "4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@edx/frontend-platform": "4.0.1", | |
"@edx/frontend-platform": "4.2.0", |
Looks like the latest version of platform is now 4.2.0
, just a note to make sure to bump to whatever the latest is when merge conflicts are resolved. https://github.com/openedx/frontend-platform/releases
package.json
Outdated
@@ -43,6 +43,8 @@ | |||
"url": "https://github.com/edx/frontend-lib-special-exams/issues" | |||
}, | |||
"dependencies": { | |||
"@edx/frontend-build": "12.7.0", | |||
"@edx/frontend-platform": "4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@edx/frontend-platform": "4.0.1", | |
"@edx/frontend-platform": "4.2.0", |
Looks like the latest version of platform is now 4.2.0
, just a note to make sure to bump to whatever the latest is when merge conflicts are resolved. https://github.com/openedx/frontend-platform/releases
…exams into bilalqamar95/node-v18-upgrade
…exams into bilalqamar95/node-v18-upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, approved!
🎉 This PR is included in version 2.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ticket
Upgrade Node Js from 16 to 18
Description
frontend-platform
&frontend-build
versionseslint
issues