Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov and add browserslist config #209

Conversation

Mashal-m
Copy link
Contributor

Ticket:
Use shared @edx/browserslist-config
Migrate from Coveralls to Codecov

  • This PR move the coverage to CI according to the new guidelines and depreciation plan of codecov
  • used a shared configuration.
    This change reduces the resultant asset bundle size.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (003f331) 90.63% compared to head (daa2007) 90.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files         216      216           
  Lines        3737     3737           
  Branches      722      722           
=======================================
  Hits         3387     3387           
  Misses        329      329           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m
Copy link
Contributor Author

Review Requested Here

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Thanks so much for this!

@abdullahwaheed
Copy link
Contributor

@connorhaugh could you please merge it as well, we don't have permissions to merge

@Mashal-m
Copy link
Contributor Author

Mashal-m commented May 9, 2023

@connorhaugh conflicts resolved, can you please merge this? :)

@connorhaugh connorhaugh merged commit 084d61f into openedx:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants