-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated frontend-build to bump jest version to v29 #369
feat: Updated frontend-build to bump jest version to v29 #369
Conversation
…t-header into bilalqamar95/frontend-build-jest-upgrade
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 70.67% 66.86% -3.81%
==========================================
Files 24 24
Lines 358 338 -20
Branches 90 78 -12
==========================================
- Hits 253 226 -27
- Misses 103 110 +7
Partials 2 2 ☔ View full report in Codecov by Sentry. |
…t-header into bilalqamar95/frontend-build-jest-upgrade
…thub.com/openedx/frontend-component-header into bilalqamar95/frontend-build-jest-upgrade
…a synced with master
…t-header into bilalqamar95/frontend-build-jest-upgrade
…t-header into bilalqamar95/frontend-build-jest-upgrade
package.json
Outdated
"react-responsive": "8.2.0", | ||
"react-transition-group": "4.4.5" | ||
}, | ||
"peerDependencies": { | ||
"@edx/frontend-platform": "^7.0.0", | ||
"@edx/frontend-platform": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@edx/frontend-platform": "^8.0.0", | |
"@edx/frontend-platform": "^7.0.0 || ^8.0.0", |
i think we should add support of frontend-platform v7 here as well because a consumer will not break if it uses v7 or v8 of frontend-platform since frontend-platform v8 doesn't have any breaking changes except frontend-build peer dependency change. Moreover, we are opening PRs in respective MFEs as well with frontend-build and frontend-platform upgrade, i think we can handle this manually in those PRs. In this way we don't have to release it as a breaking change.
Description
jest
to v29 &frontend-build
major version upgradefrontend-platform
to v8