Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #425

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jun 12, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17, along with @storybook/addon-a11y to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b246333) 73.73% compared to head (5fb4453) 73.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   73.73%   73.73%           
=======================================
  Files           3        3           
  Lines          99       99           
  Branches       29       29           
=======================================
  Hits           73       73           
  Misses         20       20           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review July 6, 2023 05:49
@Toxicom
Copy link

Toxicom commented Sep 11, 2023

Just curious, why not straight to React 18? Too much breaking changes?

@Mashal-m
Copy link
Contributor Author

Just curious, why not straight to React 18? Too much breaking changes?

Yes because of breaking changes, we are planning to upgrade React 18 after React 17.

@jmbowman
Copy link

Is anything blocking progress on this? I don't see any reviewers assigned.

@Mashal-m Mashal-m requested a review from Toxicom October 23, 2023 05:39
@Mashal-m
Copy link
Contributor Author

Mashal-m commented Dec 6, 2023

@Toxicom could you please merge this?

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable update and tests are passing.

@feanil feanil merged commit 9c7784d into master Jan 29, 2024
6 checks passed
@feanil feanil deleted the mashal-m/react-upgrade-to-v17 branch January 29, 2024 14:41
@edx-semantic-release
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants