Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Internationalization of ErrorPage when Cookies aren't available #752

Merged
merged 1 commit into from
May 31, 2023

Conversation

grmartin
Copy link
Contributor

Checking to see if we have a valid Locale in English (really as a test of if messages are set) and if not, calling in a blank localization so the page doesnt simply crash.

@grmartin grmartin requested a review from a team as a code owner May 31, 2023 14:24
@grmartin
Copy link
Contributor Author

This was reported yesterday as: openedx/frontend-template-application#590

@grmartin grmartin merged commit d79bf32 into master May 31, 2023
@grmartin grmartin deleted the gmartin/error-page-i18n-fix branch May 31, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants