Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat: subsidy box points to learner credit (#810)"" #822

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

sameenfatima78
Copy link
Member

Reverts #821 so the subsidy learner credit work can be deployed again.

@sameenfatima78
Copy link
Member Author

@adamstankiewicz Hope I can merge this work back. Wanted to check with you first.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 88.93% and project coverage change: +0.15% 🎉

Comparison is base (d36b78a) 84.87% compared to head (5ef1495) 85.02%.
Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   84.87%   85.02%   +0.15%     
==========================================
  Files         320      324       +4     
  Lines        6399     6673     +274     
  Branches     1552     1616      +64     
==========================================
+ Hits         5431     5674     +243     
- Misses        941      968      +27     
- Partials       27       31       +4     
Files Changed Coverage Δ
src/components/course/CourseMainContent.jsx 100.00% <ø> (ø)
src/components/course/CourseSidebarListItem.jsx 100.00% <ø> (ø)
src/components/course/VerifiedCertPitch.jsx 100.00% <ø> (ø)
.../components/course/course-header/CourseRunCard.jsx 100.00% <ø> (ø)
...ourse-header/data/hooks/useCourseRunCardAction.jsx 100.00% <ø> (ø)
...e/course-header/data/hooks/useCourseRunCardData.js 100.00% <ø> (ø)
src/components/course/data/service.js 46.51% <ø> (ø)
...rse/enrollment/components/ToDataSharingConsent.jsx 100.00% <ø> (ø)
.../course/enrollment/components/ToEcomBasketPage.jsx 75.00% <ø> (-1.93%) ⬇️
...nt/components/ToExecutiveEducation2UEnrollment.jsx 50.00% <0.00%> (ø)
... and 90 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz
Copy link
Member

@adamstankiewicz Hope I can merge this work back. Wanted to check with you first.

@sameenfatima78 Should be all set to merge this PR back in once openedx/enterprise-access#262 is on stage, assuming it can go out to production shortly after a QA regression check on stage.

@sameenfatima78 sameenfatima78 merged commit 2f9eea2 into master Sep 19, 2023
5 checks passed
@sameenfatima78 sameenfatima78 deleted the revert-821-ags/revert-810 branch September 19, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants