Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use shared browserslist configuration #220

Merged

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Sep 21, 2022

Ticket:
Use shared @edx/browserslist-config

  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

@openedx-webhooks
Copy link

Thanks for the pull request, @Mashal-m! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 50.00% // Head: 50.00% // No change to project coverage 👍

Coverage data is based on head (b20bf46) compared to base (4d848de).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files          15       15           
  Lines         164      164           
  Branches       28       28           
=======================================
  Hits           82       82           
  Misses         77       77           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@natabene natabene changed the title build: use shared browserslist configuration build: use shared browserslist configuration Sep 23, 2022
@natabene natabene changed the title build: use shared browserslist configuration build: use shared browserslist configuration Sep 23, 2022
@Mashal-m Mashal-m closed this Oct 4, 2022
@Mashal-m Mashal-m reopened this Oct 4, 2022
@mphilbrick211 mphilbrick211 requested review from colinbrash and removed request for colinbrash October 26, 2022 02:17
@mphilbrick211
Copy link

@Mashal-m - when you are ready to have this reviewed, please tag Colin Brash. Thank you!

@Mashal-m
Copy link
Contributor Author

Ready to review.
@colinbrash

@mphilbrick211
Copy link

Hi @colinbrash - friendly ping on this :) Could you please take a look?

@zubair-ce07 zubair-ce07 self-assigned this Feb 2, 2023
@zubair-ce07 zubair-ce07 merged commit 9c60fe7 into openedx:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering review open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants