Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: posts sorting on sidebar #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dyudyunov
Copy link
Contributor

Description

Fix wrong sorting when a user creates several posts without the page reloading.

Steps to reproduce

  1. [Precondition] The new discussions experience (discussions sidebar) should be enabled
  2. Navigate to any course unit where the discussions sidebar is enabled
  3. Create a new post.
  4. Click on the "Back to list" button. Note that the default sorting is used (most recent first) and it's correct.
  5. Create another post without reloading the page
  6. Click on the "Back to list" button and check the result

Actual result

The second created post is the last in the list (the same for any number of posts created additionally).

image

Expected result (with the fix applied)

Sorting works as expected - most recent posts are displayed first.

discuss_sorting

Additional Notes

  • Reproduces only with the discussions sidebar inside the Learning MFE.
    That's because when you create a post in the Discussions MFE itself - you will be navigated to the "My Posts" tab and the list of the posts will always be fetched.
  • Sorting works as expected after the page is reloaded.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 29, 2024

Thanks for the pull request, @dyudyunov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@dyudyunov
Copy link
Contributor Author

My changes require further improvements - there are unneeded additional GET requests to the threads endpoint.

I will change the status to Draft for now

@dyudyunov dyudyunov changed the title fix: posts sorting on sidebar [DRAFT] fix: posts sorting on sidebar Apr 1, 2024
@dyudyunov dyudyunov force-pushed the fix-posts-sorting-on-sidebar branch from 7f3e838 to 97a69da Compare April 1, 2024 08:00
@dyudyunov dyudyunov changed the title [DRAFT] fix: posts sorting on sidebar fix: posts sorting on sidebar Apr 1, 2024
@dyudyunov
Copy link
Contributor Author

My changes require further improvements - there are unneeded additional GET requests to the threads endpoint.

I will change the status to Draft for now

I figured out how to get rid of the unneeded API call, now it's ready for the review

@dyudyunov
Copy link
Contributor Author

Tests CI seems to be canceled because of the timeout Error: The operation was canceled. Failing after 360m

Does anyone know the reason?

@awais-ansari
Copy link
Contributor

Tests CI seems to be canceled because of the timeout Error: The operation was canceled. Failing after 360m

Does anyone know the reason?

@dyudyunov Not sure about it.

@dyudyunov dyudyunov force-pushed the fix-posts-sorting-on-sidebar branch from 97a69da to ae6e989 Compare April 8, 2024 11:22
@dyudyunov
Copy link
Contributor Author

Rebased on fresh master branch

Hope it will fix the pipeline timeout issue

@mphilbrick211
Copy link

Hi @dyudyunov! Do you still need help with this? If so, I can look into it for you.

@dyudyunov dyudyunov force-pushed the fix-posts-sorting-on-sidebar branch from ae6e989 to 43ef4f4 Compare May 13, 2024 06:37
@dyudyunov
Copy link
Contributor Author

dyudyunov commented May 13, 2024

Hi @mphilbrick211

Sorry for the delayed response

Yes, I need some help here, the timeout issue is still reproducing (I rebased the working branch today to re-check) and I don't know the reason. I also saw that other PRs have the same issue

@mphilbrick211
Copy link

Hi @mphilbrick211

Sorry for the delayed response

Yes, I need some help here, the timeout issue is still reproducing (I rebased the working branch today to re-check) and I don't know the reason. I also saw that other PRs have the same issue

Checking on this for you, @dyudyunov!

@dyudyunov
Copy link
Contributor Author

@mphilbrick211 Hi

I still don't know the reason for the CI timeout, I'll try to reproduce it locally.

Can anyone check it and maybe provide ideas for the root cause?

Fix wrong sorting when a user creates several posts
without the page reloading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants