-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: posts sorting on sidebar #686
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @dyudyunov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
My changes require further improvements - there are unneeded additional GET requests to the threads endpoint. I will change the status to Draft for now |
7f3e838
to
97a69da
Compare
I figured out how to get rid of the unneeded API call, now it's ready for the review |
Tests CI seems to be canceled because of the timeout Does anyone know the reason? |
@dyudyunov Not sure about it. |
97a69da
to
ae6e989
Compare
Rebased on fresh master branch Hope it will fix the pipeline timeout issue |
Hi @dyudyunov! Do you still need help with this? If so, I can look into it for you. |
ae6e989
to
43ef4f4
Compare
Sorry for the delayed response Yes, I need some help here, the timeout issue is still reproducing (I rebased the working branch today to re-check) and I don't know the reason. I also saw that other PRs have the same issue |
Checking on this for you, @dyudyunov! |
43ef4f4
to
7fe7f9e
Compare
7fe7f9e
to
213909d
Compare
I still don't know the reason for the CI timeout, I'll try to reproduce it locally. Can anyone check it and maybe provide ideas for the root cause? |
Fix wrong sorting when a user creates several posts without the page reloading.
213909d
to
66e28fc
Compare
Description
Fix wrong sorting when a user creates several posts without the page reloading.
Steps to reproduce
Actual result
The second created post is the last in the list (the same for any number of posts created additionally).
Expected result (with the fix applied)
Sorting works as expected - most recent posts are displayed first.
Additional Notes
That's because when you create a post in the Discussions MFE itself - you will be navigated to the "My Posts" tab and the list of the posts will always be fetched.